From: Sridhar Boovaraghavan <sridhar_ml@yahoo.com>
To: emacs-devel@gnu.org
Subject: Re: 23.0.50 compile problem on Windows XP
Date: Thu, 04 Oct 2007 14:03:34 -0400 [thread overview]
Message-ID: <uwsu2g3k9.fsf@earthlink.net> (raw)
In-Reply-To: 47038922.10105@gnu.org
Thank you for looking into and diagnosing the problem. I have moved
the inclusion of <math.h> above "lisp.h" in the affected files and
here's a patch against HEAD that solves this issue.
Regards,
Sridhar
--
Index: data.c
===================================================================
RCS file: /sources/emacs/emacs/src/data.c,v
retrieving revision 1.278
diff -r1.278 data.c
26,33d25
< #include "lisp.h"
< #include "puresize.h"
< #include "charset.h"
< #include "buffer.h"
< #include "keyboard.h"
< #include "frame.h"
< #include "syssignal.h"
< #include "termhooks.h" /* For FRAME_KBOARD reference in y-or-n-p. */
64a57,65
> #include "lisp.h"
> #include "puresize.h"
> #include "charset.h"
> #include "buffer.h"
> #include "keyboard.h"
> #include "frame.h"
> #include "syssignal.h"
> #include "termhooks.h" /* For FRAME_KBOARD reference in y-or-n-p. */
>
Index: floatfns.c
===================================================================
RCS file: /sources/emacs/emacs/src/floatfns.c,v
retrieving revision 1.95
diff -r1.95 floatfns.c
50,51d49
< #include "lisp.h"
< #include "syssignal.h"
78a77,79
> #include "lisp.h"
> #include "syssignal.h"
>
Index: lread.c
===================================================================
RCS file: /sources/emacs/emacs/src/lread.c,v
retrieving revision 1.380
diff -r1.380 lread.c
30a31
> #include <math.h>
62,63d62
< #include <math.h>
<
Index: print.c
===================================================================
RCS file: /sources/emacs/emacs/src/print.c,v
retrieving revision 1.240
diff -r1.240 print.c
25a26,38
>
> /* Work around a problem that happens because math.h on hpux 7
> defines two static variables--which, in Emacs, are not really static,
> because `static' is defined as nothing. The problem is that they are
> defined both here and in lread.c.
> These macros prevent the name conflict. */
> #if defined (HPUX) && !defined (HPUX8)
> #define _MAXLDBL print_maxldbl
> #define _NMAXLDBL print_nmaxldbl
> #endif
>
> #include <math.h>
>
48,59d60
< /* Work around a problem that happens because math.h on hpux 7
< defines two static variables--which, in Emacs, are not really static,
< because `static' is defined as nothing. The problem is that they are
< defined both here and in lread.c.
< These macros prevent the name conflict. */
< #if defined (HPUX) && !defined (HPUX8)
< #define _MAXLDBL print_maxldbl
< #define _NMAXLDBL print_nmaxldbl
< #endif
<
< #include <math.h>
<
--
Sridhar Boovaraghavan
next prev parent reply other threads:[~2007-10-04 18:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 22:42 23.0.50 compile problem on Windows XP Sridhar Boovaraghavan
2007-10-03 8:00 ` Eli Zaretskii
2007-10-03 8:16 ` dhruva
2007-10-03 8:23 ` Jason Rumney
2007-10-03 10:01 ` dhruva
2007-10-03 12:10 ` Jason Rumney
2007-10-03 12:20 ` Jason Rumney
2007-10-03 12:59 ` dhruva
2007-10-04 18:03 ` Sridhar Boovaraghavan [this message]
2007-10-04 22:11 ` Jason Rumney
2007-10-05 0:46 ` David Robinow
2007-10-05 8:02 ` Eli Zaretskii
2007-10-05 1:17 ` Sridhar Boovaraghavan
2007-10-05 8:06 ` Eli Zaretskii
2007-10-05 8:00 ` Eli Zaretskii
2007-10-05 8:11 ` Jason Rumney
2007-10-05 8:30 ` Eli Zaretskii
2007-10-06 13:14 ` Richard Stallman
2007-10-13 12:49 ` Eli Zaretskii
2007-10-05 9:31 ` Eli Zaretskii
2007-10-05 10:00 ` dhruva
2007-10-05 10:16 ` Eli Zaretskii
2007-10-05 7:56 ` Eli Zaretskii
2007-10-05 8:08 ` Jason Rumney
2007-10-05 8:19 ` Eli Zaretskii
2007-10-05 8:21 ` dhruva
2007-10-05 8:31 ` Eli Zaretskii
2007-10-05 8:53 ` dhruva
2007-10-03 12:19 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uwsu2g3k9.fsf@earthlink.net \
--to=sridhar_ml@yahoo.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.