vc-next-action on unregistered files

vc-next-action on unregistered files

[Christoph Conrad]

In GNU Emacs 23.0.50 (i386-msvc-nt5.1.2600)
 of 2008-01-11 on CLEOPATRA
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-msvc (13.10)'

vc-next-action does not work anymore on unregistered files for me. It
does nothing on "C-x v v". Explicit M-x vc-register works.

in vc-next-action:

     ;; Files aren't registered
     ((not state)
      (mapc 'vc-register files))

state is 'unregistered from previous `vc-state'. So testing (not state)
is obviously wrong.

Re: vc-next-action on unregistered files

[Dan Nicolaescu]

"Christoph Conrad" <christoph.conrad@gmx.de> writes:

  > In GNU Emacs 23.0.50 (i386-msvc-nt5.1.2600)
  >  of 2008-01-11 on CLEOPATRA
  > Windowing system distributor `Microsoft Corp.', version 5.1.2600
  > configured using `configure --with-msvc (13.10)'
  > 
  > vc-next-action does not work anymore on unregistered files for me. It
  > does nothing on "C-x v v". Explicit M-x vc-register works.
  > 
  > in vc-next-action:
  > 
  >      ;; Files aren't registered
  >      ((not state)
  >       (mapc 'vc-register files))
  > 
  > state is 'unregistered from previous `vc-state'. So testing (not state)
  > is obviously wrong.

Thanks for the bug report, it should be fixed now.

Re: vc-next-action on unregistered files

[Christoph Conrad]

Hi Dan,

> Thanks for the bug report, it should be fixed now.

Can test it on next monday, but the change looks good. Thank you!

With kind regards,
Christoph

Re: vc-next-action on unregistered files

[Christoph Conrad]

Hi Dan,

> Thanks for the bug report, it should be fixed now.

Tested, yes, works.

The message "Previous master file has vanished. Make a new one? " is
new, isn't it? I wondered what it means seeing it the first time, and
looked into the source. Doesn't it simply mean "You really want to
register this file? "?

With kind regards,
Christoph

Re: vc-next-action on unregistered files

[Dan Nicolaescu]

"Christoph Conrad" <christoph.conrad@gmx.de> writes:

  > Hi Dan,
  > 
  > > Thanks for the bug report, it should be fixed now.
  > 
  > Tested, yes, works.
  > 
  > The message "Previous master file has vanished. Make a new one? " is
  > new, isn't it? I wondered what it means seeing it the first time, and
  > looked into the source. Doesn't it simply mean "You really want to
  > register this file? "?

Hi,

That message should only appear if the file you are trying to register
is already registered with the version control system in use. (The
terminology used in the message seems to be from RCS, which is not that
helpful nowadays when very few people are familiar with RCS...).
If you get the message in a different situation, it might be a bug. In
that case please send a step by step description of what you did when
you got the message. 

Thanks

Re: vc-next-action on unregistered files

[Christoph Conrad]

Hi Dan,

> That message should only appear if the file you are trying to register
> is already registered with the version control system in use.

No, it's displayed when the file is unregistered. See:

(if (vc-registered fname)
    (error "This file is already registered")
  (unless (y-or-n-p "Previous master file has vanished.  Make a new one? ")
    (error "Aborted")))

With kind regards,
Christoph

Re: vc-next-action on unregistered files

[Dan Nicolaescu]

"Christoph Conrad" <christoph.conrad@gmx.de> writes:

  > Hi Dan,
  > 
  > > That message should only appear if the file you are trying to register
  > > is already registered with the version control system in use.
  > 
  > No, it's displayed when the file is unregistered. See:
  > 
  > (if (vc-registered fname)
  >     (error "This file is already registered")
  >   (unless (y-or-n-p "Previous master file has vanished.  Make a new one? ")
  >     (error "Aborted")))

Look at the context, that code is inside a (when (vc-backend fname) ...

Re: vc-next-action on unregistered files

[Christoph Conrad]

Hi Dan,

> Look at the context, that code is inside a (when (vc-backend fname)
> ...

I updated my Emacs to current CVS (before 2008-01-11), now it works as
expected.

With kind regards,
Christoph