From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: emacsclient: support `/' directory separator on w32
Date: Sat, 25 Nov 2006 12:35:08 +0200
Message-ID: <uvel36cgz.fsf@gnu.org>
References: <20061124054526.72239.qmail@web62511.mail.re1.yahoo.com>
	<45678B18.2010101@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: main.gmane.org
X-Trace: sea.gmane.org 1164451353 6103 80.91.229.2 (25 Nov 2006 10:42:33 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sat, 25 Nov 2006 10:42:33 +0000 (UTC)
Cc: mmaug@yahoo.com, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 25 11:42:30 2006
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1GnuzN-0007qX-MN
	for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 11:42:29 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1GnuzN-0005LN-68
	for ged-emacs-devel@m.gmane.org; Sat, 25 Nov 2006 05:42:29 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1GnusO-0008VK-2m
	for emacs-devel@gnu.org; Sat, 25 Nov 2006 05:35:16 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1GnusM-0008U8-7s
	for emacs-devel@gnu.org; Sat, 25 Nov 2006 05:35:14 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1GnusK-0008TW-GR
	for emacs-devel@gnu.org; Sat, 25 Nov 2006 05:35:12 -0500
Original-Received: from [192.114.186.73] (helo=heller.inter.net.il)
	by monty-python.gnu.org with esmtp (Exim 4.52)
	id 1GnusI-0006Z8-G3; Sat, 25 Nov 2006 05:35:10 -0500
Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-232-240.inter.net.il
	[83.130.232.240]) by heller.inter.net.il (MOS 3.7.3a-GA)
	with ESMTP id BCB34746 (AUTH halo1);
	Sat, 25 Nov 2006 12:35:07 +0200 (IST)
Original-To: Jason Rumney <jasonr@gnu.org>
In-reply-to: <45678B18.2010101@gnu.org> (message from Jason Rumney on Sat, 25
	Nov 2006 00:15:20 +0000)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:62779
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/62779>

> Date: Sat, 25 Nov 2006 00:15:20 +0000
> From: Jason Rumney <jasonr@gnu.org>
> Cc: Emacs Devel <emacs-devel@gnu.org>
> 
>  if (islower (tolower (filename[0]))
> 
> This looks strange. Is there a good reason not to use isalpha() here?

Are we 110% sure the drive letter can be only something for which
isalpha returns a non-zero value?  What about isalpha in non-English
locales, for example?

Perhaps we should just test that the second character is a colon, and
leave the first one alone?