From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Console based mouse face highlighting. Date: Sun, 13 May 2007 06:42:40 +0300 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179027770 23906 80.91.229.12 (13 May 2007 03:42:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 13 May 2007 03:42:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 13 05:42:47 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hn4yt-0000s7-CK for ged-emacs-devel@m.gmane.org; Sun, 13 May 2007 05:42:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hn56U-0005zz-7o for ged-emacs-devel@m.gmane.org; Sat, 12 May 2007 23:50:38 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hn56R-0005yD-Io for emacs-devel@gnu.org; Sat, 12 May 2007 23:50:35 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hn56P-0005uu-Qu for emacs-devel@gnu.org; Sat, 12 May 2007 23:50:35 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hn56P-0005uj-OH for emacs-devel@gnu.org; Sat, 12 May 2007 23:50:33 -0400 Original-Received: from romy.inter.net.il ([213.8.233.24]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hn4yn-000440-Ln for emacs-devel@gnu.org; Sat, 12 May 2007 23:42:41 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-84-228-200-202.inter.net.il [84.228.200.202]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id HVF84150 (AUTH halo1); Sun, 13 May 2007 06:42:40 +0300 (IDT) In-reply-to: <17990.21422.577087.305723@kahikatea.snap.net.nz> (message from Nick Roberts on Sun, 13 May 2007 11:54:22 +1200) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70945 Archived-At: > From: Nick Roberts > Date: Sun, 13 May 2007 11:54:22 +1200 > Cc: emacs-devel@gnu.org > > OK, thanks, that helped. I've now replaced calls to x_y_to_hpos_vpos with > code in that file. It looks a bit better now, but the mouse highlighting > is from text adjacent to the pointer, appears in a slightly different location > and only when there is some input e.g a mouse click, and remains until I do > a refresh (^L). I'm afraid I don't quite understand what you are saying here. What do you mean by ``mouse highlighting is from text adjacent to the pointer''? can you show an image or describe this with a specific example? Also, in what ``slightly different location'' does the highlight appear? > 1) Does write_glyphs *overwrite* existing glyphs (while insert_glyphs adds > to them) ? Yes (on both accounts). More accurately, write_glyphs simply dumps the glyphs to the screen (with a call to fwrite), which on a tty will overwrite whatever is displayed in the respective screen locations, while insert_glyphs first switches the screen to insert mode, and then calls write_glyphs. > It would be nice if a comment said what these functions do. Feel free to add comments. Personally, I think the code speaks very well for itself (I didn't write it), but that's me. > 2) After a call to write_glyphs, does the cursor position move? I'm not sure. Why is this important? Anyway, Emacs always repositions the cursor at point at redisplay end. > 3) Any hints on frame updating ? (both xterm.c and msdos.c use dpyinfo) Sorry, I don't understand the question. Please elaborate.