From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Failure in building Emacs 23.0.50 on Cygwin Date: Sat, 01 Sep 2007 11:09:25 +0300 Message-ID: References: <20070901091956.1876@blackhawk> <200709010035.l810Zwni021513@oogie-boogie.ics.uci.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1188634181 11615 80.91.229.12 (1 Sep 2007 08:09:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 1 Sep 2007 08:09:41 +0000 (UTC) Cc: dhenman@gmail.com, emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 01 10:09:40 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IRO2y-0001zr-VT for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 10:09:37 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRO2x-0002fF-I6 for ged-emacs-devel@m.gmane.org; Sat, 01 Sep 2007 04:09:35 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IRO2s-0002eb-1l for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:09:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IRO2p-0002dr-FD for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:09:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRO2o-0002dm-S2 for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:09:26 -0400 Original-Received: from nitzan.inter.net.il ([213.8.233.22]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IRO2o-0003XT-Ea for emacs-devel@gnu.org; Sat, 01 Sep 2007 04:09:26 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-59-157.inter.net.il [80.230.59.157]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id HRL26737 (AUTH halo1); Sat, 1 Sep 2007 11:06:40 +0300 (IDT) In-reply-to: <200709010035.l810Zwni021513@oogie-boogie.ics.uci.edu> (message from Dan Nicolaescu on Fri, 31 Aug 2007 17:35:58 -0700) X-Detected-Kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77535 Archived-At: > From: Dan Nicolaescu > Date: Fri, 31 Aug 2007 17:35:58 -0700 > Cc: emacs-devel@gnu.org > > > > term.o: In function `dissociate_if_controlling_tty': > > > /tmp/emacs/src/term.c:3146: undefined reference to `_croak' > > > > > > I believe, the problem is that "croak" is not being properly defined in the > > "sysdep.c" file. It is only manifested when trying to compile term.c which refers to croak. > > > > How should one define "croak" in sysdep.c for "i686-pc-cygwin" to test this? > > Ref: config.log:Target: i686-pc-cygwin > > IMO the question should be asked the other way: how do you avoid > references to "croak". I think this is not a good idea. If multi-tty relies on `croak' to flag features that various ports need to implement, then `croak' should be available for all platforms, at least until such time as all the main supported platforms implement all such features. (Personally, I would leave `croak' in Emacs even after that, since it's such a small function, but that's me.) > Adjust preprocessor code in dissociate_if_controlling_tty so that > croak is not used. That's sweeping the problem under the carpet; not a good idea, IMO.