From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Allan Newsgroups: gmane.emacs.help Subject: Re: image-dired shows images as text Date: Fri, 28 Dec 2007 21:43:25 -0600 Organization: Posted via Supernews, http://www.supernews.com Message-ID: References: Reply-To: noreply@accessdenied.xxx NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1198903237 13786 80.91.229.12 (29 Dec 2007 04:40:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 29 Dec 2007 04:40:37 +0000 (UTC) To: help-gnu-emacs@gnu.org Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Sat Dec 29 05:40:50 2007 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J8TVB-0008Ng-Na for geh-help-gnu-emacs@m.gmane.org; Sat, 29 Dec 2007 05:40:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J8TUq-000605-HR for geh-help-gnu-emacs@m.gmane.org; Fri, 28 Dec 2007 23:40:28 -0500 Original-Path: shelby.stanford.edu!headwall.stanford.edu!newshub.sdsu.edu!newsfeed.freenet.de!multikabel.net!feed20.multikabel.net!sn-xt-ams-06!sn-xt-ams-05!sn-post-ams-02!sn-post-sjc-01!supernews.com!corp.supernews.com!not-for-mail Original-Newsgroups: gnu.emacs.help User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (windows-nt) Cancel-Lock: sha1:bfB3Ax+yd4kfQeNARV99YGvjRK0= Original-X-Complaints-To: abuse@supernews.com Original-Lines: 56 Original-Xref: shelby.stanford.edu gnu.emacs.help:154955 X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.help:50377 Archived-At: Nick Roberts writes: > I've checked the change below into CVS. If Emacs can't find convert it should > now say so with this patch. Can you please try to apply it and then post what > Emacs says to the mailing list. > > -- > Nick http://www.inet.net.nz/~nickrob > > > *** thumbs.el.~1.35.~ 2007-07-27 09:22:25.000000000 +1200 > --- thumbs.el 2007-12-28 21:01:18.000000000 +1300 > *************** ARG any arguments to the ACTION command, > *** 248,262 **** > OUTPUT-FORMAT is the file format to output (default is jpeg), > ACTION-PREFIX is the symbol to place before the ACTION command > (defaults to '-' but can sometimes be '+')." > ! (let ((command (format "%s %s%s %s \"%s\" \"%s:%s\"" > ! thumbs-conversion-program > ! (or action-prefix "-") > ! action > ! (or arg "") > ! filein > ! (or output-format "jpeg") > ! fileout))) > ! (call-process shell-file-name nil nil nil shell-command-switch command))) > > (defun thumbs-new-image-size (s increment) > "New image (a cons of width x height)." > --- 248,259 ---- > OUTPUT-FORMAT is the file format to output (default is jpeg), > ACTION-PREFIX is the symbol to place before the ACTION command > (defaults to '-' but can sometimes be '+')." > ! (call-process thumbs-conversion-program nil nil nil > ! (or action-prefix "-") > ! action > ! (or arg "") > ! filein > ! (format "%s:%s" (or output-format "jpeg") fileout))) > > (defun thumbs-new-image-size (s increment) > "New image (a cons of width x height)." I will try to apply the patch, but in the meantime I may have discovered some pertinent information. On Windows XP there is a DOS-style command called "convert" which can be accessed inside a command-prompt window. I wonder if there could be a conflict or confusion with this module? c:/WINDOWS/SYSTEM32: total used in directory 495476 available 13243296 -rw-rw-rw- 1 XXXXXXX root 333 2001-09-12 $ncsp$.inf -rw-rw-rw- 1 XXXXXXX root 860 2002-01-27 $winnt$.inf drwxrwxrwx 1 XXXXXXX root 0 12-28 07:32 . drwxrwxrwx 1 XXXXXXX root 0 12-28 14:25 .. .... -rwxrwxrwx 1 XXXXXXX root 13824 2001-08-18 convert.exe .... The way I found this out was that I tried the ImageMagick test in a command window : "convert logo: logo.gif" and got an error instead. When I navigated to the ImageMagick install directory using a DOS-style "cd" command it worked. If you append the ImageMagick directory to the end of the "PATH" environment variable the MS Windows "convert.exe" will be found first. -- Allan