* custom-deps and term subdir
@ 2008-10-01 9:11 Eli Zaretskii
2008-10-01 13:37 ` Stefan Monnier
2008-10-01 16:43 ` Glenn Morris
0 siblings, 2 replies; 9+ messages in thread
From: Eli Zaretskii @ 2008-10-01 9:11 UTC (permalink / raw)
To: emacs-devel; +Cc: Markus Rost
lisp/Makefile.in specifically avoids descending into lisp/term for
generating cus-load.el. What are the reasons for that?
I cannot find in the archives anything that would explain the reason.
Markus, it's your change (although quite some time ago) -- do you
remember why you did that?
What bothers me is how do we get the defcustom's defined by term/*.el
files.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-01 9:11 custom-deps and term subdir Eli Zaretskii
@ 2008-10-01 13:37 ` Stefan Monnier
2008-10-02 1:01 ` Richard M. Stallman
2008-10-01 16:43 ` Glenn Morris
1 sibling, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2008-10-01 13:37 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Markus Rost, emacs-devel
> lisp/Makefile.in specifically avoids descending into lisp/term for
> generating cus-load.el. What are the reasons for that?
> I cannot find in the archives anything that would explain the reason.
> Markus, it's your change (although quite some time ago) -- do you
> remember why you did that?
> What bothers me is how do we get the defcustom's defined by term/*.el
> files.
It might date back to the time when the files in lisp/term were not safe
to load (i.e. loading them would have all kinds of side effects).
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-01 13:37 ` Stefan Monnier
@ 2008-10-02 1:01 ` Richard M. Stallman
2008-10-02 5:01 ` Markus Rost
0 siblings, 1 reply; 9+ messages in thread
From: Richard M. Stallman @ 2008-10-02 1:01 UTC (permalink / raw)
To: Stefan Monnier; +Cc: rost, eliz, emacs-devel
It might date back to the time when the files in lisp/term were not safe
to load (i.e. loading them would have all kinds of side effects).
They are not all safe to load. For instance, ns-win.el
will give an error if you're not on MacOS.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-02 1:01 ` Richard M. Stallman
@ 2008-10-02 5:01 ` Markus Rost
2008-10-02 18:24 ` Eli Zaretskii
0 siblings, 1 reply; 9+ messages in thread
From: Markus Rost @ 2008-10-02 5:01 UTC (permalink / raw)
To: rms; +Cc: eliz, monnier, emacs-devel
Eli wrote:
> Markus, it's your change (although quite some time ago) -- do you
> remember why you did that?
At some time I had looked into this, but it seems that Gerd made that
specific change:
2001-08-15 Gerd Moellmann <gerd@gnu.org>
* Makefile.in (finder_setwins): Renamed from
nonobsolete_setwins.
Don't include term/.
I think that term was excluded because for custom options in term/*.el
the related load files may depend on the system.
For instance, in Emacs as of 2004-03-10 there were the following
defcustom's in lisp/term/*:
./pc-win.el:176:(defcustom x-select-enable-clipboard t
./x-win.el:2106:(defcustom x-select-enable-clipboard nil
I am not aware of a clean way to set such dependencies correctly.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-02 5:01 ` Markus Rost
@ 2008-10-02 18:24 ` Eli Zaretskii
2008-10-02 19:00 ` Stefan Monnier
2008-10-02 21:29 ` Markus Rost
0 siblings, 2 replies; 9+ messages in thread
From: Eli Zaretskii @ 2008-10-02 18:24 UTC (permalink / raw)
To: Markus Rost; +Cc: emacs-devel, rms, monnier
> From: Markus Rost <rost@math.uni-bielefeld.de>
> CC: monnier@iro.umontreal.ca, eliz@gnu.org, emacs-devel@gnu.org
> Date: Thu, 2 Oct 2008 07:01:37 +0200 (CEST)
>
> Eli wrote:
>
> > Markus, it's your change (although quite some time ago) -- do you
> > remember why you did that?
>
> At some time I had looked into this, but it seems that Gerd made that
> specific change:
>
> 2001-08-15 Gerd Moellmann <gerd@gnu.org>
>
> * Makefile.in (finder_setwins): Renamed from
> nonobsolete_setwins.
> Don't include term/.
That's not the change I was talking about. I was talking about this
one:
2002-11-20 Markus Rost <rost@math.ohio-state.edu>
* Makefile.in (setwins_almost): Renamed from finder_setwins.
(custom-deps): Use it.
(finder-data): Adjust to that name change.
This is where custom-deps started using setwins_almost. Before that,
it was only used in finder-data (under a different name, but the name
is not what bothers me).
I can understand why finder-inf.el can live without the term
subdirectory: there should be no optional packages in there. But
custom-deps is quite another matter, I think.
> For instance, in Emacs as of 2004-03-10 there were the following
> defcustom's in lisp/term/*:
>
> ./pc-win.el:176:(defcustom x-select-enable-clipboard t
> ./x-win.el:2106:(defcustom x-select-enable-clipboard nil
x-select-enable-clipboard is an important user option. We shouldn't
miss it, I think.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-02 18:24 ` Eli Zaretskii
@ 2008-10-02 19:00 ` Stefan Monnier
2008-10-02 21:29 ` Markus Rost
1 sibling, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2008-10-02 19:00 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Markus Rost, rms, emacs-devel
>> For instance, in Emacs as of 2004-03-10 there were the following
>> defcustom's in lisp/term/*:
>>
>> ./pc-win.el:176:(defcustom x-select-enable-clipboard t
>> ./x-win.el:2106:(defcustom x-select-enable-clipboard nil
> x-select-enable-clipboard is an important user option. We shouldn't
> miss it, I think.
Agreed. It should be moved out of those files into the common code.
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-02 18:24 ` Eli Zaretskii
2008-10-02 19:00 ` Stefan Monnier
@ 2008-10-02 21:29 ` Markus Rost
1 sibling, 0 replies; 9+ messages in thread
From: Markus Rost @ 2008-10-02 21:29 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel, rms, monnier
> That's not the change I was talking about. I was talking about this
> one:
>
>
> 2002-11-20 Markus Rost <rost@math.ohio-state.edu>
>
> * Makefile.in (setwins_almost): Renamed from finder_setwins.
> (custom-deps): Use it.
> (finder-data): Adjust to that name change.
>
> This is where custom-deps started using setwins_almost. Before that,
> it was only used in finder-data (under a different name, but the name
> is not what bothers me).
>
Yes, I think you are right. Sorry, it is a long time ago.
> x-select-enable-clipboard is an important user option. We shouldn't
> miss it, I think.
I agree. However I am not aware of a clean fix.
Anyway, I don't have time to spend on Emacs. Nevertheless it was nice
to hear from you guys after these many years.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-01 9:11 custom-deps and term subdir Eli Zaretskii
2008-10-01 13:37 ` Stefan Monnier
@ 2008-10-01 16:43 ` Glenn Morris
2008-10-01 17:08 ` Eli Zaretskii
1 sibling, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2008-10-01 16:43 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Markus Rost, emacs-devel
Eli Zaretskii wrote:
> What bothers me is how do we get the defcustom's defined by term/*.el
> files.
There are only 5 of them, and the relevant files always get dumped.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: custom-deps and term subdir
2008-10-01 16:43 ` Glenn Morris
@ 2008-10-01 17:08 ` Eli Zaretskii
0 siblings, 0 replies; 9+ messages in thread
From: Eli Zaretskii @ 2008-10-01 17:08 UTC (permalink / raw)
To: Glenn Morris; +Cc: rost, emacs-devel
> From: Glenn Morris <rgm@gnu.org>
> Cc: emacs-devel@gnu.org, Markus Rost <rost@math.uni-bielefeld.de>
> Date: Wed, 01 Oct 2008 12:43:49 -0400
>
> Eli Zaretskii wrote:
>
> > What bothers me is how do we get the defcustom's defined by term/*.el
> > files.
>
> There are only 5 of them, and the relevant files always get dumped.
Today, perhaps. Tomorrow, who knows? At the very least we should add
a prominent comment in lisp/Makefile.in, where wins_almost is
computed, as to why we exclude two directories, and what changes might
invalidate that exclusion.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-10-02 21:29 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-01 9:11 custom-deps and term subdir Eli Zaretskii
2008-10-01 13:37 ` Stefan Monnier
2008-10-02 1:01 ` Richard M. Stallman
2008-10-02 5:01 ` Markus Rost
2008-10-02 18:24 ` Eli Zaretskii
2008-10-02 19:00 ` Stefan Monnier
2008-10-02 21:29 ` Markus Rost
2008-10-01 16:43 ` Glenn Morris
2008-10-01 17:08 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.