define tab for dired-buffer selection

define tab for dired-buffer selection

[Fabian Braennstroem]

Hi,

I often have multiple windows with some dired and some
text-mode buffers. Now, I would like to
 define 'tab' to switch just dired between dired windows.
Would be nice, if this works somehow!?
My first approach was:
(defun dired-change-window()
  "Change to the other buffer"
  (interactive)
  (if (eq major-mode 'dired-mode) (other-window 1)
  (while (not (eq major-mode 'dired-mode)) (other-window 1))
       ))

But this jumps in every window!?

Regards!
Fabian

Re: define tab for dired-buffer selection

[Peter Dyballa]

Am 09.09.2007 um 22:36 schrieb Fabian Braennstroem:

> Now, I would like to
>  define 'tab' to switch just dired between dired windows.

Have you thought of adding this (other-window) as a local key binding  
to dired-mode-map?

--
Mit friedvollen Grüßen

   Pete

Wer eher stirbt ist schon 'mal länger tot!

Re: define tab for dired-buffer selection

[Fabian Braennstroem]

Hi Peter,

Peter Dyballa schrieb am 09/09/2007 09:36 PM:
> Am 09.09.2007 um 22:36 schrieb Fabian Braennstroem:
> 
>> Now, I would like to
>>  define 'tab' to switch just dired between dired windows.
> 
> Have you thought of adding this (other-window) as a local key binding  
> to dired-mode-map?

No, but it should actually not affect any other buffer; the
tab should just walk through the visible open dired
buffers... but you are right, it would be enough to define
it for dired-mode-map.

Fabian

Re: define tab for dired-buffer selection

[Mathias Dahl]

Fabian Braennstroem <f.braennstroem@gmx.de> writes:


> My first approach was:
> (defun dired-change-window()
>   "Change to the other buffer"
>   (interactive)
>   (if (eq major-mode 'dired-mode) (other-window 1)
>   (while (not (eq major-mode 'dired-mode)) (other-window 1))
>        ))

This seems to work:

(defun dired-change-window()
  "Change to the other buffer"
  (interactive)
  (if (eq major-mode 'dired-mode)
      (select-window
       (get-window-with-predicate
        (lambda (x) 
          (eq
           (save-excursion (set-buffer (window-buffer x))
                           major-mode)
           'dired-mode))))))

I cannot say exactly why your code does not work though. Maybe the
major-mode does not change because you never really changes buffers.

/Mathias

Re: define tab for dired-buffer selection

[Fabian Braennstroem]

Hi Mathias,

sorry for the late response!

Mathias Dahl schrieb am 09/12/2007 03:53 PM:
> Fabian Braennstroem <f.braennstroem@gmx.de> writes:
> 
> 
>> My first approach was:
>> (defun dired-change-window()
>>   "Change to the other buffer"
>>   (interactive)
>>   (if (eq major-mode 'dired-mode) (other-window 1)
>>   (while (not (eq major-mode 'dired-mode)) (other-window 1))
>>        ))
> 
> This seems to work:
> 
> (defun dired-change-window()
>   "Change to the other buffer"
>   (interactive)
>   (if (eq major-mode 'dired-mode)
>       (select-window
>        (get-window-with-predicate
>         (lambda (x) 
>           (eq
>            (save-excursion (set-buffer (window-buffer x))
>                            major-mode)
>            'dired-mode))))))
> 
> I cannot say exactly why your code does not work though. Maybe the
> major-mode does not change because you never really changes buffers.

Thanks, it works well!
Fabian