all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] Fix headers in some testing lisp files
@ 2024-03-10 10:46 Max Nikulin
  2024-03-13 12:36 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Max Nikulin @ 2024-03-10 10:46 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

Hi,

Looking for a file suitable for a new portion of unit tests I have 
noticed some inconsistencies in first lines of files.

for i in testing/lisp/*.el ; do
     base="$(basename "$i")";
     if [ -z "$(sed -n -e "1s/$base//p" "$i")" ]; then
          printf '%s:1: ' "$i" ;
          head -1 "$i" ;
     fi ;
done

testing/lisp/test-ob-julia.el:1: ;;; test-ob-python.el --- tests for 
ob-python.el  -*- lexical-binding: t; -*-
testing/lisp/test-ol-bbdb.el:1: ;;; test-org-bbdb.el --- tests for 
org-bbdb.el                        -*- lexical-binding: t; -*-
testing/lisp/test-org-fold.el:1: ;;; test-org.el --- tests for org.el 
-*- lexical-binding: t; -*-
testing/lisp/test-ox-ascii.el:1: ;;; test-ox-latex.el --- tests for 
ox-latex.el       -*- lexical-binding: t; -*-

[-- Attachment #2: 0001-testing-Fix-file-names-in-file-headers.patch --]
[-- Type: text/x-patch, Size: 2519 bytes --]

From 030556adf3b072e6f27388beea4bd769ca870abc Mon Sep 17 00:00:00 2001
From: Max Nikulin <manikulin@gmail.com>
Date: Sat, 9 Mar 2024 14:06:38 +0700
Subject: [PATCH 1/3] testing: Fix file names in file headers

* testing/lisp/test-ob-julia.el:
* testing/lisp/test-ol-bbdb.el:
* testing/lisp/test-org-fold.el:
* testing/lisp/test-ox-ascii.el: Fix names in file headers.

Inconsistency was likely caused by copy-paste.
---
 testing/lisp/test-ob-julia.el | 2 +-
 testing/lisp/test-ol-bbdb.el  | 4 ++--
 testing/lisp/test-org-fold.el | 2 +-
 testing/lisp/test-ox-ascii.el | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/testing/lisp/test-ob-julia.el b/testing/lisp/test-ob-julia.el
index f5666a93a..447297262 100644
--- a/testing/lisp/test-ob-julia.el
+++ b/testing/lisp/test-ob-julia.el
@@ -1,4 +1,4 @@
-;;; test-ob-python.el --- tests for ob-python.el  -*- lexical-binding: t; -*-
+;;; test-ob-julia.el --- tests for ob-julia.el  -*- lexical-binding: t; -*-
 
 ;; Copyright (c) 2011-2014, 2019, 2021 Eric Schulte
 ;; Authors: Pedro Bruel, based on test-ob-python.el by Eric Schulte
diff --git a/testing/lisp/test-ol-bbdb.el b/testing/lisp/test-ol-bbdb.el
index 114e46218..25f6c22e0 100644
--- a/testing/lisp/test-ol-bbdb.el
+++ b/testing/lisp/test-ol-bbdb.el
@@ -1,4 +1,4 @@
-;;; test-org-bbdb.el --- tests for org-bbdb.el                        -*- lexical-binding: t; -*-
+;;; test-ol-bbdb.el --- tests for ol-bbdb.el                        -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2018, 2019  Marco Wahl
 
@@ -20,7 +20,7 @@ ;;; test-org-bbdb.el --- tests for org-bbdb.el                        -*- lexica
 
 ;;; Commentary:
 
-;; Test some of org-bbdb.el.
+;; Test some of ol-bbdb.el.
 
 ;;; Code:
 
diff --git a/testing/lisp/test-org-fold.el b/testing/lisp/test-org-fold.el
index dd532cc8b..f58642be6 100644
--- a/testing/lisp/test-org-fold.el
+++ b/testing/lisp/test-org-fold.el
@@ -1,4 +1,4 @@
-;;; test-org.el --- tests for org.el  -*- lexical-binding: t; -*-
+;;; test-org-fold.el --- tests for org-fold.el  -*- lexical-binding: t; -*-
 
 ;; Authors: Ihor Radchenko
 
diff --git a/testing/lisp/test-ox-ascii.el b/testing/lisp/test-ox-ascii.el
index b93fdbdeb..2df1bd795 100644
--- a/testing/lisp/test-ox-ascii.el
+++ b/testing/lisp/test-ox-ascii.el
@@ -1,4 +1,4 @@
-;;; test-ox-latex.el --- tests for ox-latex.el       -*- lexical-binding: t; -*-
+;;; test-ox-ascii.el --- tests for ox-ascii.el       -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2023  Ihor Radchenko
 
-- 
2.39.2


[-- Attachment #3: 0002-testing-Fix-misleading-file-headers.patch --]
[-- Type: text/x-patch, Size: 1454 bytes --]

From 36f32ac3d952c7369045a883c1b58eea49a143d5 Mon Sep 17 00:00:00 2001
From: Max Nikulin <manikulin@gmail.com>
Date: Sat, 9 Mar 2024 17:33:51 +0700
Subject: [PATCH 2/3] testing: Fix misleading file headers

* testing/lisp/test-org-tempo.el:
* testing/lisp/test-property-inheritance.el: Do not refer to
non-existing file names in the file header.
---
 testing/lisp/test-org-tempo.el            | 2 +-
 testing/lisp/test-property-inheritance.el | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testing/lisp/test-org-tempo.el b/testing/lisp/test-org-tempo.el
index e4c2b9184..0760d4532 100644
--- a/testing/lisp/test-org-tempo.el
+++ b/testing/lisp/test-org-tempo.el
@@ -1,4 +1,4 @@
-;;; test-org-tempo.el --- Tests for test-org-tempo.el     -*- lexical-binding: t; -*-
+;;; test-org-tempo.el --- Tests for org-tempo.el     -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2017, 2019 Rasmus Pank Roulund
 
diff --git a/testing/lisp/test-property-inheritance.el b/testing/lisp/test-property-inheritance.el
index ede25b490..c8976d6cc 100644
--- a/testing/lisp/test-property-inheritance.el
+++ b/testing/lisp/test-property-inheritance.el
@@ -1,4 +1,4 @@
-;;; test-property-inheritance.el --- tests for property-inheritance.el  -*- lexical-binding: t; -*-
+;;; test-property-inheritance.el --- tests of property inheritance  -*- lexical-binding: t; -*-
 
 ;; Copyright (c) 2011-2014, 2019 Eric Schulte
 ;; Authors: Eric Schulte
-- 
2.39.2


[-- Attachment #4: 0003-testing-Add-missing-lexical-binding-modeline.patch --]
[-- Type: text/x-patch, Size: 1211 bytes --]

From 2f5475109ee6b698d21ba28a40e1d5db6cbf7185 Mon Sep 17 00:00:00 2001
From: Max Nikulin <manikulin@gmail.com>
Date: Sat, 9 Mar 2024 17:35:23 +0700
Subject: [PATCH 3/3] testing: Add missing lexical-binding modeline

* testing/lisp/test-ox-html.el:
* testing/lisp/test-ox-texinfo.el: Add modeline with `lexical-binding'.
---
 testing/lisp/test-ox-html.el    | 2 +-
 testing/lisp/test-ox-texinfo.el | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/testing/lisp/test-ox-html.el b/testing/lisp/test-ox-html.el
index cbe272ef8..0959d1441 100644
--- a/testing/lisp/test-ox-html.el
+++ b/testing/lisp/test-ox-html.el
@@ -1,4 +1,4 @@
-;;; test-ox-html.el --- Tests for ox-html.el
+;;; test-ox-html.el --- Tests for ox-html.el  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2022  Rudolf Adamkovič
 
diff --git a/testing/lisp/test-ox-texinfo.el b/testing/lisp/test-ox-texinfo.el
index f69b2ad6d..b67d2f4c1 100644
--- a/testing/lisp/test-ox-texinfo.el
+++ b/testing/lisp/test-ox-texinfo.el
@@ -1,4 +1,4 @@
-;;; test-ox-texinfo.el --- Tests for ox-texinfo.el
+;;; test-ox-texinfo.el --- Tests for ox-texinfo.el  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2022  Rudolf Adamkovič
 
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix headers in some testing lisp files
  2024-03-10 10:46 [PATCH] Fix headers in some testing lisp files Max Nikulin
@ 2024-03-13 12:36 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2024-03-13 12:36 UTC (permalink / raw)
  To: Max Nikulin; +Cc: emacs-orgmode

Max Nikulin <manikulin@gmail.com> writes:

> Looking for a file suitable for a new portion of unit tests I have 
> noticed some inconsistencies in first lines of files.

Thanks!
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=37a98d7de
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ff5fc2563
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ca2929094

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-13 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-10 10:46 [PATCH] Fix headers in some testing lisp files Max Nikulin
2024-03-13 12:36 ` Ihor Radchenko

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.