From: Ulrich Mueller <ulm@gentoo.org>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 61460@debbugs.gnu.org
Subject: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon
Date: Wed, 22 Feb 2023 12:32:30 +0100 [thread overview]
Message-ID: <usfeyorzl@gentoo.org> (raw)
In-Reply-To: <87y1oq3tm0.fsf@web.de> (Michael Heerdegen's message of "Wed, 22 Feb 2023 11:03:03 +0100")
>>>>> On Wed, 22 Feb 2023, Michael Heerdegen wrote:
> Ulrich Mueller <ulm@gentoo.org> writes:
>> It is probably a matter of personal taste, but I dislike the nested
>> concats. This seems simpler (not tested, though):
>>
>> - (cons mark (concat (lunar-phase-name (nth 2 phase)) " "
>> - (cadr phase))))))
>> + (cons mark
>> + (let ((eclipse (nth 3 phase)))
>> + (concat (lunar-phase-name (nth 2 phase)) " "
>> + (cadr phase)
>> + (if (string-empty-p eclipse) "" " ")
>> + eclipse))))))
> Fine by me (my preference would be Andreas' suggestion).
Use something like ‘(unless (string-empty-p eclipse) " ")’? WFM.
> We also need to fix the space handling in calendar-lunar-phases aka M in
> calendar - when no eclipse occurs, the descriptions end with a
> trailing space.
While at it, maybe replace ‘(car (last x))’ by ‘(nth 3 x)’?
next prev parent reply other threads:[~2023-02-22 11:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 19:57 bug#61460: 30.0.50; Calendar shows eclipse for quarter moon Ulrich Mueller
2023-02-12 20:07 ` Ulrich Müller
2023-02-12 20:19 ` Eli Zaretskii
2023-02-12 21:13 ` Ulrich Mueller
2023-02-13 3:24 ` Eli Zaretskii
2023-02-13 3:25 ` Michael Heerdegen
2023-02-13 4:52 ` Michael Heerdegen
2023-02-13 5:13 ` Michael Heerdegen
2023-02-13 6:01 ` Michael Heerdegen
2023-02-13 7:28 ` Ulrich Mueller
2023-02-13 8:13 ` Michael Heerdegen
2023-02-13 8:52 ` Michael Heerdegen
2023-02-13 9:34 ` Ulrich Mueller
2023-02-13 10:04 ` Michael Heerdegen
2023-02-13 13:03 ` Eli Zaretskii
2023-02-13 13:30 ` Ulrich Mueller
2023-02-13 14:05 ` Eli Zaretskii
2023-02-14 5:30 ` Michael Heerdegen
2023-02-14 7:59 ` Ulrich Mueller
2023-02-14 9:15 ` Michael Heerdegen
2023-02-14 10:22 ` Ulrich Müller
2023-02-14 10:56 ` Michael Heerdegen
2023-02-16 20:26 ` Ulrich Müller
2023-02-17 5:25 ` Michael Heerdegen
2023-02-17 7:03 ` Ulrich Müller
2023-02-17 7:20 ` Michael Heerdegen
2023-02-18 5:53 ` Michael Heerdegen
2023-02-18 8:56 ` Ulrich Mueller
2023-02-18 9:16 ` Michael Heerdegen
2023-02-21 15:15 ` Michael Heerdegen
2023-02-22 9:00 ` Ulrich Mueller
2023-02-22 9:45 ` Andreas Schwab
2023-02-22 10:03 ` Michael Heerdegen
2023-02-22 11:32 ` Ulrich Mueller [this message]
2023-02-22 14:19 ` Michael Heerdegen
2023-02-22 15:46 ` Ulrich Mueller
2023-02-22 16:26 ` Michael Heerdegen
2023-02-25 16:13 ` Michael Heerdegen
2023-02-14 13:31 ` Eli Zaretskii
2023-02-14 10:49 ` Ulrich Mueller
2023-02-13 6:21 ` Ulrich Mueller
2023-02-13 7:08 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=usfeyorzl@gentoo.org \
--to=ulm@gentoo.org \
--cc=61460@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.