all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#71749: 29.4; Test failure in flymake-tests.el with GCC 14.1.1
@ 2024-06-24 13:33 Ulrich Müller
  2024-06-24 15:00 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Müller @ 2024-06-24 13:33 UTC (permalink / raw)
  To: 71749

[-- Attachment #1: Type: text/plain, Size: 2601 bytes --]

Emacs 29.4 fails tests with GCC 14.1.1 (Gentoo package
sys-devel/gcc-14.1.1_p20240518):

HOME=/nonexistent LANG=C EMACS_TEST_DIRECTORY=/tmp/portage/app-editors/emacs-29.4/work/emacs-29.4/test   "../src/emacs" --module-assertions --no-init-file --no-site-file --no-site-lisp -L ":."  \
  -l ert --eval '(setq ert-batch-backtrace-right-margin nil)' -l src/emacs-module-tests \
  --batch --eval '(ert-run-tests-batch-and-exit (quote (not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))))' > src/emacs-module-tests.log 2>&1 || { STAT=$?; cat src/emacs-module-tests.log; exit $STAT; }
Running 9 tests (2024-06-24 15:21:29+0200, selector ‘(not (or (tag :expensive-test) (tag :unstable) (tag :nativecomp)))’)
   passed  1/9  different-diagnostic-types (1.294288 sec)
   passed  2/9  dummy-backends (1.002899 sec)
   passed  3/9  eob-region-and-trailing-newline (0.000172 sec)
Test included-c-header-files backtrace:
[... backtrace omitted ...]

Test included-c-header-files condition:
    (ert-test-failed
     ((should
       (eq 'flymake-warning
	    (face-at-point)))
      :form
      (eq flymake-warning flymake-error)
      :value nil))
   FAILED  4/9  included-c-header-files (1.067014 sec) at lisp/progmodes/flymake-tests.el:168
   passed  5/9  perl-backend (1.025399 sec)
   passed  6/9  recurrent-backend (1.003033 sec)
   passed  7/9  ruby-backend (1.019991 sec)
   passed  8/9  warning-predicate-function-gcc (1.020760 sec)
   passed  9/9  warning-predicate-rx-gcc (1.021962 sec)

Ran 9 tests, 8 results as expected, 1 unexpected (2024-06-24 15:21:38+0200, 8.529267 sec)

1 unexpected results:
   FAILED  included-c-header-files  ((should (eq 'flymake-warning (face-at-point))) :form (eq flymake-warning flymake-error) :value nil)

make[3]: *** [Makefile:180: lisp/progmodes/flymake-tests.log] Error 1
make[3]: Leaving directory '/tmp/portage/app-editors/emacs-29.4/work/emacs-29.4/test'
make[2]: [Makefile:340: check-doit] Error 2 (ignored)

SUMMARY OF TEST RESULTS
-----------------------
Files examined: 466
Ran 6977 tests, 6757 results as expected, 1 unexpected, 219 skipped
1 files contained unexpected results:
  lisp/progmodes/flymake-tests.log
make[2]: *** [Makefile:341: check-doit] Error 1
make[2]: Leaving directory '/tmp/portage/app-editors/emacs-29.4/work/emacs-29.4/test'
make[1]: *** [Makefile:310: check] Error 2
make[1]: Leaving directory '/tmp/portage/app-editors/emacs-29.4/work/emacs-29.4/test'
make: *** [Makefile:1105: check] Error 2


Attached patch (for the emacs-30 branch) fixes the problem for me:


[-- Attachment #2: 0001-Fix-flymake-tests-with-GCC-14.patch --]
[-- Type: text/plain, Size: 1112 bytes --]

From 4a36a89eb441816d18a85233fe34cf27c33f131e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
Date: Mon, 24 Jun 2024 15:20:26 +0200
Subject: [PATCH] Fix flymake tests with GCC 14.

* test/lisp/progmodes/flymake-tests.el (included-c-header-files):
Fix test failure with GCC 14.
---
 test/lisp/progmodes/flymake-tests.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/lisp/progmodes/flymake-tests.el b/test/lisp/progmodes/flymake-tests.el
index 21dbb0711d2..93bc9028031 100644
--- a/test/lisp/progmodes/flymake-tests.el
+++ b/test/lisp/progmodes/flymake-tests.el
@@ -174,7 +174,8 @@ included-c-header-files
     (flymake-tests--with-flymake
         ("some-problems.h")
       (flymake-goto-next-error)
-      (should (eq 'flymake-warning (face-at-point)))
+      ;; implicit-int was promoted from warning to error in GCC 14
+      (should (memq (face-at-point) '(flymake-warning flymake-error)))
       (flymake-goto-next-error)
       (should (eq 'flymake-error (face-at-point)))
       (should-error (flymake-goto-next-error nil nil t)))
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-24 15:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-24 13:33 bug#71749: 29.4; Test failure in flymake-tests.el with GCC 14.1.1 Ulrich Müller
2024-06-24 15:00 ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.