* mailabbrev.el bug? @ 2003-02-09 3:13 David Abrahams 2003-02-10 10:35 ` Richard Stallman 2003-02-10 10:53 ` Andreas Schwab 0 siblings, 2 replies; 4+ messages in thread From: David Abrahams @ 2003-02-09 3:13 UTC (permalink / raw) Unless define-abbrev has changed its signature since 21.2.1, I found a bug in mailabbrev.el, which I fixed with this patch: *** mailabbrev.el.~1.71.~ Sun Jan 12 15:48:49 2003 --- mailabbrev.el Sat Feb 8 21:39:43 2003 *************** *** 315,321 **** (setq name (downcase name)) ;; use an abbrev table instead of an alist for mail-abbrevs. (let ((abbrevs-changed abbrevs-changed)) ; protect this from being changed. ! (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 t))) (defun mail-resolve-all-aliases () --- 315,322 ---- (setq name (downcase name)) ;; use an abbrev table instead of an alist for mail-abbrevs. (let ((abbrevs-changed abbrevs-changed)) ; protect this from being changed. ! (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 ;t ;; dwa -- this seems to be an extra argument that isn't recognized by define-abbrev ! ))) (defun mail-resolve-all-aliases () -- Dave Abrahams Boost Consulting www.boost-consulting.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mailabbrev.el bug? 2003-02-09 3:13 mailabbrev.el bug? David Abrahams @ 2003-02-10 10:35 ` Richard Stallman 2003-02-10 12:13 ` David Abrahams 2003-02-10 10:53 ` Andreas Schwab 1 sibling, 1 reply; 4+ messages in thread From: Richard Stallman @ 2003-02-10 10:35 UTC (permalink / raw) Cc: emacs-devel ! (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 t))) That looks correct to me. define-abbrev takes 6 args and this seems to pass them all correctly. Why do you think it is wrong? ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mailabbrev.el bug? 2003-02-10 10:35 ` Richard Stallman @ 2003-02-10 12:13 ` David Abrahams 0 siblings, 0 replies; 4+ messages in thread From: David Abrahams @ 2003-02-10 12:13 UTC (permalink / raw) Cc: emacs-devel Richard Stallman <rms@gnu.org> writes: > ! (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 t))) > > That looks correct to me. define-abbrev takes 6 args and this seems > to pass them all correctly. Why do you think it is wrong? Anly because it gave me an error when I replaced my 21.2.1 elisp/mail folder with the CVS... I realize it's undisciplined, but you know how GNUs users are; we always want something that's not supported in the release ;-). -- Dave Abrahams Boost Consulting www.boost-consulting.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: mailabbrev.el bug? 2003-02-09 3:13 mailabbrev.el bug? David Abrahams 2003-02-10 10:35 ` Richard Stallman @ 2003-02-10 10:53 ` Andreas Schwab 1 sibling, 0 replies; 4+ messages in thread From: Andreas Schwab @ 2003-02-10 10:53 UTC (permalink / raw) Cc: emacs-devel David Abrahams <dave@boost-consulting.com> writes: |> Unless define-abbrev has changed its signature since 21.2.1, It has. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-02-10 12:13 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2003-02-09 3:13 mailabbrev.el bug? David Abrahams 2003-02-10 10:35 ` Richard Stallman 2003-02-10 12:13 ` David Abrahams 2003-02-10 10:53 ` Andreas Schwab
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.