From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David Abrahams Newsgroups: gmane.emacs.devel Subject: mailabbrev.el bug? Date: Sat, 08 Feb 2003 22:13:46 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1044760398 7329 80.91.224.249 (9 Feb 2003 03:13:18 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 9 Feb 2003 03:13:18 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18hhu9-0001u2-00 for ; Sun, 09 Feb 2003 04:13:17 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18hi4T-0000tv-00 for ; Sun, 09 Feb 2003 04:23:57 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18hhvJ-0006mX-03 for emacs-devel@quimby.gnus.org; Sat, 08 Feb 2003 22:14:29 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18hhuz-0006lT-00 for emacs-devel@gnu.org; Sat, 08 Feb 2003 22:14:09 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18hhuy-0006lI-00 for emacs-devel@gnu.org; Sat, 08 Feb 2003 22:14:08 -0500 Original-Received: from main.gmane.org ([80.91.224.249]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18hhux-0006lD-00 for emacs-devel@gnu.org; Sat, 08 Feb 2003 22:14:08 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18hhst-0001qC-00 for ; Sun, 09 Feb 2003 04:11:59 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 18hhss-0001q2-00 for ; Sun, 09 Feb 2003 04:11:58 +0100 Original-Lines: 29 Original-X-Complaints-To: usenet@main.gmane.org User-Agent: Gnus/5.090014 (Oort Gnus v0.14) Emacs/21.2 (i386-msvc-nt5.1.2600) Cancel-Lock: sha1:c9cTZ40+/8Xgn3WPpcEqfagn/o0= X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:11510 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11510 Unless define-abbrev has changed its signature since 21.2.1, I found a bug in mailabbrev.el, which I fixed with this patch: *** mailabbrev.el.~1.71.~ Sun Jan 12 15:48:49 2003 --- mailabbrev.el Sat Feb 8 21:39:43 2003 *************** *** 315,321 **** (setq name (downcase name)) ;; use an abbrev table instead of an alist for mail-abbrevs. (let ((abbrevs-changed abbrevs-changed)) ; protect this from being changed. ! (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 t))) (defun mail-resolve-all-aliases () --- 315,322 ---- (setq name (downcase name)) ;; use an abbrev table instead of an alist for mail-abbrevs. (let ((abbrevs-changed abbrevs-changed)) ; protect this from being changed. ! (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 ;t ;; dwa -- this seems to be an extra argument that isn't recognized by define-abbrev ! ))) (defun mail-resolve-all-aliases () -- Dave Abrahams Boost Consulting www.boost-consulting.com