mailabbrev.el bug?

mailabbrev.el bug?

[David Abrahams]

Unless define-abbrev has changed its signature since 21.2.1, I found a
bug in mailabbrev.el, which I fixed with this patch:

*** mailabbrev.el.~1.71.~	Sun Jan 12 15:48:49 2003
--- mailabbrev.el	Sat Feb  8 21:39:43 2003
***************
*** 315,321 ****
    (setq name (downcase name))
    ;; use an abbrev table instead of an alist for mail-abbrevs.
    (let ((abbrevs-changed abbrevs-changed))  ; protect this from being changed.
!     (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 t)))
  
  
  (defun mail-resolve-all-aliases ()
--- 315,322 ----
    (setq name (downcase name))
    ;; use an abbrev table instead of an alist for mail-abbrevs.
    (let ((abbrevs-changed abbrevs-changed))  ; protect this from being changed.
!     (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 ;t  ;; dwa -- this seems to be an extra argument that isn't recognized by define-abbrev
!       )))
  
  
  (defun mail-resolve-all-aliases ()

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com

Re: mailabbrev.el bug?

[Richard Stallman]

    !     (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 t)))

That looks correct to me.  define-abbrev takes 6 args and this seems
to pass them all correctly.  Why do you think it is wrong?

Re: mailabbrev.el bug?

[Andreas Schwab]

David Abrahams <dave@boost-consulting.com> writes:

|> Unless define-abbrev has changed its signature since 21.2.1,

It has.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: mailabbrev.el bug?

[David Abrahams]

Richard Stallman <rms@gnu.org> writes:

>     !     (define-abbrev mail-abbrevs name definition 'mail-abbrev-expand-hook 0 t)))
>
> That looks correct to me.  define-abbrev takes 6 args and this seems
> to pass them all correctly.  Why do you think it is wrong?

Anly because it gave me an error when I replaced my 21.2.1 elisp/mail
folder with the CVS... I realize it's undisciplined, but you know how
GNUs users are; we always want something that's not supported in the
release ;-).

-- 
Dave Abrahams
Boost Consulting
www.boost-consulting.com