From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: request for review: Doing direct file I/O in Emacs Lisp
Date: 10 May 2004 17:04:41 +0200
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <ur7tsfhme.fsf@gnu.org>
References: <m2d65cx1ow.fsf@Majnun.local> <jebrkw7hby.fsf@sykes.suse.de>
	<upt9cplki.fsf@gnu.org> <je3c687cgv.fsf@sykes.suse.de>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1084213320 24456 80.91.224.253 (10 May 2004 18:22:00 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 10 May 2004 18:22:00 +0000 (UTC)
Cc: johnw@gnu.org, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon May 10 20:21:53 2004
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BNFPV-0004qK-00
	for <emacs-devel@deer.gmane.org>; Mon, 10 May 2004 20:21:53 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BNFPV-0007eK-00
	for <emacs-devel@quimby.gnus.org>; Mon, 10 May 2004 20:21:53 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34)
	id 1BNFOR-00031H-TF
	for emacs-devel@quimby.gnus.org; Mon, 10 May 2004 14:20:47 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34)
	id 1BNFFL-00017M-GG
	for emacs-devel@gnu.org; Mon, 10 May 2004 14:11:23 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34)
	id 1BNFDv-0000WF-KX
	for emacs-devel@gnu.org; Mon, 10 May 2004 14:10:28 -0400
Original-Received: from [207.232.27.5] (helo=WST0054)
	by monty-python.gnu.org with asmtp (Exim 4.33)
	id 1BNBMR-0005fk-ES; Mon, 10 May 2004 10:02:28 -0400
Original-To: Andreas Schwab <schwab@suse.de>
In-reply-to: <je3c687cgv.fsf@sykes.suse.de> (message from Andreas Schwab on
	Mon, 10 May 2004 13:23:12 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:23060
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23060

> From: Andreas Schwab <schwab@suse.de>
> Date: Mon, 10 May 2004 13:23:12 +0200
> 
> How can you find out which error happend?  There are already three
> different cases where the function just returns nil, and the caller would
> have to repeat the very same tests to find out which error path was taken.

You are right, we do throw errors in other file-related primitives, so
I guess we should do that here as well.

> Argument type checks should just use CHECK_FOO.

Agreed.