From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Abrahams Newsgroups: gmane.emacs.devel Subject: Re: [PING] ClearType Patch Date: Wed, 08 Jun 2005 11:46:58 -0400 Message-ID: References: <1117787455.42a0153fdf46f@webmail.freedom2surf.net> <1118072836.42a47004de422@webmail.freedom2surf.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1118245590 26776 80.91.229.2 (8 Jun 2005 15:46:30 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Jun 2005 15:46:30 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 08 17:46:21 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dg2jd-0005be-Cv for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 17:44:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dg2qM-0002sq-UG for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 11:51:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dg2pO-0002Wr-Cz for emacs-devel@gnu.org; Wed, 08 Jun 2005 11:50:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dg2pL-0002UU-0d for emacs-devel@gnu.org; Wed, 08 Jun 2005 11:50:47 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dg2pK-0002Tn-HO for emacs-devel@gnu.org; Wed, 08 Jun 2005 11:50:46 -0400 Original-Received: from [207.172.4.63] (helo=smtp04.mrf.mail.rcn.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dg2pW-0007we-Ne; Wed, 08 Jun 2005 11:50:58 -0400 Original-Received: from 146-115-127-135.c3-0.smr-ubr2.sbo-smr.ma.cable.rcn.com (HELO i9300.boost-consulting.com) (146.115.127.135) by smtp04.mrf.mail.rcn.net with ESMTP; 08 Jun 2005 11:46:58 -0400 X-IronPort-AV: i="3.93,183,1115006400"; d="scan'208"; a="44625875:sNHT23984012" Original-Received: from dave by i9300.boost-consulting.com with local (Exim 4.50) id IHRVUA-0000PG-BA; Wed, 08 Jun 2005 11:46:58 -0400 Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Wed, 08 Jun 2005 17:33:07 +0300") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38339 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38339 Eli Zaretskii writes: >> From: David Abrahams >> Date: Wed, 08 Jun 2005 09:45:16 -0400 >> >> Sorry to be a pest, but as easy as it was, solving this problem did >> take significant effort on my part. > > Thank you for your work. > > However, with only a few days past, you could have waited a few more > before deciding that your patches were ignored. Sorry, but I have a lot on my plate, so once I start waiting a few more days it's likely to drop off my radar screen. >> So could someone please either render a judgement about how the patch >> should be changed, or check it in as is, or give me CVS write >> permission so I can do it myself? > > I'm bothered by the funky W32_* macros, so I'd like to hear from > people who know more than myself about the intricacies of MSVC and > MinGW whether there's no cleaner way to do this. Hard-coding macros > from system headers (that's what those #define's are, right?) Yep. > in Emacs doesn't sound like a good idea to me. Agreed, but I think the use of -D_WIN32_WINNT=0x0400 on the compiler command-line may be similarly bad (and is the reason I transcribed those constants). > Also, according to what I see in the MinGW headers, I'm not sure I > understand the problem. I see SPI_GETFONTSMOOTHING in winuser.h, > whose definition is unaffected by the value of _WIN32_WINNT. I'm compiling with msvc 7.1; I don't know what MinGW does. > I don't > see the other two constants in the MinGW headers. So please explain > in more detail the problem that caused you to define your own macros: > what macros you wanted to use, SPI_GETFONTSMOOTHING This one is in fact available for _WIN32_WINNT == 0x400; I should have used it directly. SPI_GETFONTSMOOTHINGTYPE FE_FONTSMOOTHINGCLEARTYPE These two are only enabled for _WIN32_WINNT >= 0x0501 > where they are defined, WinUser.h, IIRC > and why the value of _WIN32_WINNT prevents you from using them. Because they are #ifdef'd out when _WIN32_WINNT takes certain values. > Finally, MSDN seems to indicate that SPI_GETFONTSMOOTHINGTYPE is > unsupported on Windows 9x, so it sounds like your code should be > disabled for those versions of Windows. Right, I should use an #ifdef _WIN32_WINNT >= 0x0501 ... except of course that the build process subverts that by forcing _WIN32_WINNT to 0x400. > A ChangeLog entry for the patches would also be nice, btw. I will be happy to write one. I assume the format to follow is used in the ChangeLog file at the top of emacs' CVS tree? -- Dave Abrahams Boost Consulting www.boost-consulting.com