From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Preventing warnings in FIXNUM_OVERFLOW_P
Date: Sat, 20 Jan 2007 15:45:25 +0200 [thread overview]
Message-ID: <ur6tpvmkq.fsf@gnu.org> (raw)
In-Reply-To: <E1H85gq-0004pu-Aw@fencepost.gnu.org> (message from Richard Stallman on Fri, 19 Jan 2007 21:10:44 -0500)
> From: Richard Stallman <rms@gnu.org>
> CC: eliz@gnu.org, emacs-devel@gnu.org
> Date: Fri, 19 Jan 2007 21:10:44 -0500
>
> > I say let's leave my workaround alone until the GCC developers move
> > this warning into -Wextra. When that version of GCC becomes
> > widespread, we can remove the workaround.
>
> Agreed,
>
> That is a bad solution. Turning off this warning globally risks
> missing other places where there is a real problem. The right
> solution is a way to turn off the warning _only in this construct_.
But this argument is applicable to _every_ warning GCC is programmed
to emit! including those that are already in -Wall and -Wextra, about
which you yourself argued in the past that they should not be issued
by default.
Every warning can sometimes flag code that is a real problem, that's
the reason we have those warnings in the first place. If we are to
accept your argument, why not use -Wall globally, and then go over the
warnings and turn each one only in those places where we know the code
is correct?
next prev parent reply other threads:[~2007-01-20 13:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 17:27 Preventing warnings in FIXNUM_OVERFLOW_P Richard Stallman
2007-01-18 18:34 ` David Kastrup
2007-01-18 19:39 ` Stefan Monnier
2007-01-19 10:42 ` Richard Stallman
2007-01-19 11:50 ` Eli Zaretskii
2007-01-19 19:19 ` Stefan Monnier
2007-01-20 2:10 ` Richard Stallman
2007-01-20 13:45 ` Eli Zaretskii [this message]
2007-01-21 6:49 ` Richard Stallman
2007-01-19 10:42 ` Richard Stallman
2007-01-18 21:49 ` Eli Zaretskii
2007-01-19 10:43 ` Richard Stallman
2007-01-19 10:57 ` Eli Zaretskii
2007-01-20 2:10 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ur6tpvmkq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.