From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: vc making coding system nil, latexenc not protecting Date: Mon, 24 Sep 2007 23:32:18 +0200 Message-ID: References: <200709241337.l8ODb4D26498@f7.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1190669639 14386 80.91.229.12 (24 Sep 2007 21:33:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 24 Sep 2007 21:33:59 +0000 (UTC) Cc: neldredge@math.ucsd.edu, emacs-devel@gnu.org To: karl@freefriends.org (Karl Berry) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 24 23:33:54 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IZvYn-0006sm-DP for ged-emacs-devel@m.gmane.org; Mon, 24 Sep 2007 23:33:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IZvYk-00074n-LB for ged-emacs-devel@m.gmane.org; Mon, 24 Sep 2007 17:33:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IZvYg-00070f-Lb for emacs-devel@gnu.org; Mon, 24 Sep 2007 17:33:38 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IZvYg-0006zc-2l for emacs-devel@gnu.org; Mon, 24 Sep 2007 17:33:38 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IZvYf-0006zQ-QQ for emacs-devel@gnu.org; Mon, 24 Sep 2007 17:33:37 -0400 Original-Received: from heller.inter.net.il ([213.8.233.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IZvYf-0004T8-D1 for emacs-devel@gnu.org; Mon, 24 Sep 2007 17:33:37 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-208-248.inter.net.il [80.230.208.248]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id DSB41751 (AUTH halo1); Mon, 24 Sep 2007 23:32:17 +0200 (IST) In-reply-to: <200709241337.l8ODb4D26498@f7.net> (karl@freefriends.org) X-Detected-Kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:79760 Archived-At: > Date: Mon, 24 Sep 2007 08:37:04 -0500 > From: karl@freefriends.org (Karl Berry) > Cc: neldredge@math.ucsd.edu > > lisp/international/latexenc.el: > (coding-system-base ;Disregard the EOL part of the CS. > (with-current-buffer latexenc-main-buffer > (or coding-system-for-write buffer-file-coding-system)))) > > Both coding-system-for-write and buffer-file-coding-system are nil, and > thus coding-system-base throws the error. It seems it would be > desirable to avoid the call and hence the error in this case -- if I > take out the call, for testing, everything goes through fine. Or else > to change coding-system-base to be a no-op if its arg is nil. Why no-op? nil means undecided, AFAIK, so that's what the code should do. (Actually, perhaps it's better to change coding-system-base to do that automagically, but I cannot say if this is safe without grepping the sources for uses of coding-system-base.) > The second question is why both those variables are nil in the first > place. After visiting the file, but before running CTRL-x v v, > buffer-file-coding-system is undecided-unix. So somewhere within > vc-next-action it got set to nil. That may be, but please note that there's nothing wrong with the value of nil. > I could not find where. (Aside: too bad edebug doesn't have > watchpoints.) If you mean you want to watch buffer-file-coding-system, then it's a buffer-specific variable, so it's stored somewhere in the buffer structure; you could set a watchpoint on the C level.