From: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: "Preserve owner and group" on MSDOS/Windows
Date: Fri, 24 Jun 2005 13:45:22 +0200 [thread overview]
Message-ID: <upsucx9kd.fsf@gnu.org> (raw)
In-Reply-To: <f7ccd24b05062402087cf11dd5@mail.gmail.com> (message from Juanma Barranquero on Fri, 24 Jun 2005 11:08:20 +0200)
> Date: Fri, 24 Jun 2005 11:08:20 +0200
> From: Juanma Barranquero <lekktu@gmail.com>
>
> This change fails on Windows (no chown function):
>
> 2005-06-23 Richard M. Stallman <rms@gnu.org>
>
> * fileio.c (Frename_file): Preserve owner and group, if possible,
> when copying.
>
> I've wrapped it with #ifndef DOS_NT. I don't think any other action is needed.
I don't think this is the best solution. It is IMHO much better to
add to w32.c a trivial `chown' that does nothing; then the ugly ifdef
can go away. (The DOS port doesn't need the ifdef anyway, since the
DJGPP library already has such a no-op implementation of `chown'.)
I think system-dependcent ifdef's should be the last resort in such
situations.
I've just installed a change along these lines (and undid yours).
(A more meaningful implementation of `chown' for w32, that uses
GetNamedSecurityInfo and SetNamedSecurityInfo, is left as an exercise
to the reader ;-)
next prev parent reply other threads:[~2005-06-24 11:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-24 9:08 "Preserve owner and group" on MSDOS/Windows Juanma Barranquero
2005-06-24 11:45 ` Eli Zaretskii [this message]
2005-06-24 11:02 ` Juanma Barranquero
2005-06-24 15:07 ` Race-condition ? (was: "Preserve owner and group" on MSDOS/Windows) Gaëtan LEURENT
2005-06-24 20:07 ` Eli Zaretskii
2005-06-24 20:46 ` Race-condition ? Gaëtan LEURENT
2005-06-25 9:27 ` Eli Zaretskii
2005-06-24 21:01 ` David Kastrup
2005-06-25 22:25 ` Gaëtan LEURENT
2005-06-26 18:48 ` David Kastrup
2005-06-26 4:46 ` Race-condition ? (was: "Preserve owner and group" on MSDOS/Windows) Richard M. Stallman
2005-06-26 19:52 ` Race-condition ? Gaëtan LEURENT
2005-06-27 5:38 ` Richard M. Stallman
2005-06-28 22:57 ` Gaëtan LEURENT
2005-06-28 23:50 ` Lennart Borgman
2005-06-30 5:42 ` David Kastrup
2005-07-03 15:49 ` Richard M. Stallman
2005-06-26 4:46 ` Race-condition ? (was: "Preserve owner and group" on MSDOS/Windows) Richard M. Stallman
2005-06-26 17:12 ` Race-condition ? Gaëtan LEURENT
2005-06-26 18:59 ` Race-condition ? (was: "Preserve owner and group" on MSDOS/Windows) Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=upsucx9kd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.