From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Proposal: Windows Control Panel Colors Date: 05 Jun 2003 00:00:52 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20030604213300.9151.qmail@web80511.mail.yahoo.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1054768280 8928 80.91.224.249 (4 Jun 2003 23:11:20 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2003 23:11:20 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Jun 05 01:11:10 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19NhPS-0002JI-00 for ; Thu, 05 Jun 2003 01:11:10 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19NhhF-0000lI-00 for ; Thu, 05 Jun 2003 01:29:33 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19NhQg-0007cV-KH for emacs-devel@quimby.gnus.org; Wed, 04 Jun 2003 19:12:26 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19NhNj-0007BB-7y for emacs-devel@gnu.org; Wed, 04 Jun 2003 19:09:23 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19NhJu-0006H1-1k for emacs-devel@gnu.org; Wed, 04 Jun 2003 19:05:28 -0400 Original-Received: from server0011.freedom2surf.net ([194.106.56.14] helo=server0027.freedom2surf.net) by monty-python.gnu.org with esmtp (Exim 4.20) id 19NhFc-0005hB-Ry for emacs-devel@gnu.org; Wed, 04 Jun 2003 19:01:00 -0400 Original-Received: from wanchan.jasonr.f2s.com ([195.137.103.251]) h54N0xPW010105; Wed, 4 Jun 2003 23:00:59 GMT Original-Received: from NYAUMO (nyaumo.jasonr.f2s.com [10.0.0.27]) by wanchan.jasonr.f2s.com (Postfix) with ESMTP id 5EE6EDDF15; Thu, 5 Jun 2003 00:00:59 +0100 (BST) Original-To: Michael Mauger In-Reply-To: <20030604213300.9151.qmail@web80511.mail.yahoo.com> Original-Lines: 24 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14720 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14720 Michael Mauger writes: > Can we get agreement on the first part of the patch (i.e., loading > the Windows control panel colors onto `w32-color-map') and leave > the second portion of the patch (i.e., mapping specific faces to > use the the control panel colors) off? That way, those of us who > wish to use the control panel colors can, by customizing the faces, > but the current defaults can stand. My only concern with the effect of your patch is basing the modeline face on titlebar colors. The rest of the changes do not seem likely to cause complaints. As far as the implementation details go, I'd like to rewrite the patch to comply with GNU coding guidelines and reduce the complexity of the for statement. Also, I think it would be better to use a more generic prefix so we can have some commonality if the same thing is done on other platforms (it may be useful for GTK, Mac and maybe even CDE users to be able to use color names that correspond to the system settings rather than physical colors). If you'd like to contribute to Emacs in future, it may be worth it for you to make these changes and arrange the neccesary copyright assignments. Otherwise I will try to do it over the next few days.