all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* RMAIL against Texinfo
@ 2004-02-01 17:16 Eli Zaretskii
  2004-02-01 21:51 ` Kai Grossjohann
  0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2004-02-01 17:16 UTC (permalink / raw)
  Cc: Karl Berry

Recently, I became annoyed by the fact that when I reply to a message
sent via texinfo-pretest or texinfo-help mailing lists, the list
address is somehow removed from the list of addressees to whom my
reply is sent.  After some debugging, it turned out that the default
value of rmail-dont-reply-to-names was this:

    "info-\\|eliz@elta\\.co\\.il>\\|eliz\\>"

And that "info-" thingie would remove texinfo-* lists from my replies!

That seems like a simple bug to me: the intent was to remove the
"info-*" mailing lists, which are essentially read-only (you are sent
information, but are not supposed to reply), so the regexp should
have been anchored at the beginning of a word, like this:

    "\\<info-\\|\\<eliz@elta\\.co\\.il\\>\\|\\<eliz\\>"

(I think my username and email addresses should get the same anchors,
to avoid filtering out someone whose username happens to be "noteliz",
for example.)

However, given that the code, both in rmail.el and in mail-utils.el,
which did this is VERY old, I'd like to ask if someone sees any bad
side effects from the changes I suggest below.

TIA

Index: lisp/mail/rmail.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/rmail.el,v
retrieving revision 1.378
diff -u -r1.378 rmail.el
--- lisp/mail/rmail.el	30 Dec 2003 11:42:37 -0000	1.378
+++ lisp/mail/rmail.el	1 Feb 2004 17:18:49 -0000
@@ -139,9 +139,9 @@
   :group 'rmail-reply)
 
 ;;;###autoload
-(defvar rmail-default-dont-reply-to-names "info-" "\
-A regular expression specifying part of the value of the default value of
-the variable `rmail-dont-reply-to-names', for when the user does not set
+(defvar rmail-default-dont-reply-to-names "\\<info-" "\
+A regular expression specifying part of the default value of the
+variable `rmail-dont-reply-to-names', for when the user does not set
 `rmail-dont-reply-to-names' explicitly.  (The other part of the default
 value is the user's email address and name.)
 It is useful to set this variable in the site customization file.")


Index: lisp/mail/mail-utils.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/mail/mail-utils.el,v
retrieving revision 1.54
diff -u -r1.54 mail-utils.el
--- lisp/mail/mail-utils.el	1 Sep 2003 15:45:29 -0000	1.54
+++ lisp/mail/mail-utils.el	1 Feb 2004 17:19:39 -0000
@@ -216,9 +216,11 @@
                       "")
                     (if (and user-mail-address
                              (not (equal user-mail-address user-login-name)))
-                        (concat (regexp-quote user-mail-address) "\\|")
+                        (concat "\\<"
+				(regexp-quote user-mail-address)
+				"\\>\\|")
                       "")
-                    (concat (regexp-quote user-login-name) "\\>"))))
+                    (concat "\\<" (regexp-quote user-login-name) "\\>"))))
   ;; Split up DESTINATIONS and match each element separately.
   (let ((start-pos 0) (cur-pos 0)
 	(case-fold-search t))

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2004-02-03 10:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-01 17:16 RMAIL against Texinfo Eli Zaretskii
2004-02-01 21:51 ` Kai Grossjohann
2004-02-02  5:59   ` Eli Zaretskii
2004-02-02  7:33     ` Kai Grossjohann
2004-02-02 19:04       ` Eli Zaretskii
2004-02-03  8:34         ` Kai Grossjohann
2004-02-03 10:13           ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.