From: Eli Zaretskii <eliz@gnu.org>
Cc: andrewi@gnu.org
Subject: w32_abort can return
Date: Sat, 11 Jun 2005 23:43:22 +0300 [thread overview]
Message-ID: <uoeac7hg5.fsf@gnu.org> (raw)
The W32 build of Emacs redefines `abort' thusly:
#define abort w32_abort
on s/ms-w32.h, and then defines `w32_abort' on w32fns.c. Since
config.h is included before all the other headers, when the compiler
sees stdlib.h, where there's a prototype of `abort', it thinks that
`w32_abort' is a function that doesn't return, because `abort' is
declared in stdlib.h as such.
However, `w32_abort' does in fact return, if the user clicks "Ignore"
on the dialog it pops up.
This causes the compiler to produce incorrect code for every place
where Emacs calls `abort'. It also causes a warning when compiling
w32fns.c, which is how I became aware of the problem in the first
place.
I don't see any easy way of solving this problem except if we modify
`w32_abort' to never return, even if the user clicks "Ignore".
Personally, I don't see any reason to support the Ignore option. Is
it okay to call, e.g., `exit' in that case instead of returning?
TIA
next reply other threads:[~2005-06-11 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-11 20:43 Eli Zaretskii [this message]
2005-06-11 21:18 ` w32_abort can return Jason Rumney
2005-06-12 11:33 ` Eli Zaretskii
2005-06-12 10:30 ` Richard Stallman
2005-06-12 11:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uoeac7hg5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrewi@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.