* endianness test in md5.c
@ 2008-10-18 8:27 Ulrich Mueller
2008-10-18 9:06 ` Andreas Schwab
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Mueller @ 2008-10-18 8:27 UTC (permalink / raw
To: emacs-devel
src/md5.c contains the following code:
# include <endian.h>
# if __BYTE_ORDER == __BIG_ENDIAN
# define WORDS_BIG_ENDIAN 1
# endif
I wonder, shouldn't it just use the macro defined in m/*.h instead
(at least for the case that HAVE_CONFIG_H is defined)?
Ulrich
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: endianness test in md5.c
2008-10-18 8:27 endianness test in md5.c Ulrich Mueller
@ 2008-10-18 9:06 ` Andreas Schwab
2008-10-18 9:15 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2008-10-18 9:06 UTC (permalink / raw
To: Ulrich Mueller; +Cc: emacs-devel
Ulrich Mueller <ulm@gentoo.org> writes:
> src/md5.c contains the following code:
>
> # include <endian.h>
> # if __BYTE_ORDER == __BIG_ENDIAN
> # define WORDS_BIG_ENDIAN 1
> # endif
>
> I wonder, shouldn't it just use the macro defined in m/*.h instead
> (at least for the case that HAVE_CONFIG_H is defined)?
This is only used when compiled as part of glibc.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: endianness test in md5.c
2008-10-18 9:06 ` Andreas Schwab
@ 2008-10-18 9:15 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2008-10-18 9:15 UTC (permalink / raw
To: Andreas Schwab; +Cc: ulm, emacs-devel
> From: Andreas Schwab <schwab@suse.de>
> Date: Sat, 18 Oct 2008 11:06:57 +0200
> Cc: emacs-devel@gnu.org
>
> Ulrich Mueller <ulm@gentoo.org> writes:
>
> > src/md5.c contains the following code:
> >
> > # include <endian.h>
> > # if __BYTE_ORDER == __BIG_ENDIAN
> > # define WORDS_BIG_ENDIAN 1
> > # endif
> >
> > I wonder, shouldn't it just use the macro defined in m/*.h instead
> > (at least for the case that HAVE_CONFIG_H is defined)?
>
> This is only used when compiled as part of glibc.
Exactly. And md5.c is imported from glibc, so we don't want to make
local changes to it that are not necessary for Emacs, to make
importing future versions easier.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-18 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-18 8:27 endianness test in md5.c Ulrich Mueller
2008-10-18 9:06 ` Andreas Schwab
2008-10-18 9:15 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.