From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: endianness test in md5.c Date: Sat, 18 Oct 2008 11:15:50 +0200 Message-ID: References: <18681.40417.666597.580033@a1ihome1.kph.uni-mainz.de> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1224321423 17362 80.91.229.12 (18 Oct 2008 09:17:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Oct 2008 09:17:03 +0000 (UTC) Cc: ulm@gentoo.org, emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 18 11:18:04 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kr7wc-0000H4-GS for ged-emacs-devel@m.gmane.org; Sat, 18 Oct 2008 11:17:59 +0200 Original-Received: from localhost ([127.0.0.1]:40666 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kr7vU-0003KY-GJ for ged-emacs-devel@m.gmane.org; Sat, 18 Oct 2008 05:16:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Kr7vO-0003KJ-I0 for emacs-devel@gnu.org; Sat, 18 Oct 2008 05:16:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Kr7vL-0003K7-LL for emacs-devel@gnu.org; Sat, 18 Oct 2008 05:16:41 -0400 Original-Received: from [199.232.76.173] (port=44076 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Kr7vL-0003K4-Fz for emacs-devel@gnu.org; Sat, 18 Oct 2008 05:16:39 -0400 Original-Received: from mtaout1.012.net.il ([84.95.2.1]:8921) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kr7vL-0002mr-ML for emacs-devel@gnu.org; Sat, 18 Oct 2008 05:16:40 -0400 Original-Received: from HOME-C4E4A596F7 ([77.126.98.197]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K8X00FYAGGQL3B0@i-mtaout1.012.net.il> for emacs-devel@gnu.org; Sat, 18 Oct 2008 11:17:15 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104587 Archived-At: > From: Andreas Schwab > Date: Sat, 18 Oct 2008 11:06:57 +0200 > Cc: emacs-devel@gnu.org > > Ulrich Mueller writes: > > > src/md5.c contains the following code: > > > > # include > > # if __BYTE_ORDER == __BIG_ENDIAN > > # define WORDS_BIG_ENDIAN 1 > > # endif > > > > I wonder, shouldn't it just use the macro defined in m/*.h instead > > (at least for the case that HAVE_CONFIG_H is defined)? > > This is only used when compiled as part of glibc. Exactly. And md5.c is imported from glibc, so we don't want to make local changes to it that are not necessary for Emacs, to make importing future versions easier.