From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#2738: Content-free doc string: `handle-shift-selection'. Date: Mon, 23 Mar 2009 06:20:54 +0200 Message-ID: References: <20090321172343.GB6890@muc.de> <20090322225915.GA4466@muc.de> Reply-To: Eli Zaretskii , 2738@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1237783454 23722 80.91.229.12 (23 Mar 2009 04:44:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Mar 2009 04:44:14 +0000 (UTC) Cc: 2738@emacsbugs.donarmstrong.com To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 23 05:45:31 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Llc2T-0002bt-Fn for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Mar 2009 05:45:29 +0100 Original-Received: from localhost ([127.0.0.1]:52318 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Llc16-0000rI-Rm for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Mar 2009 00:44:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Llc0u-0000nL-MI for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2009 00:43:52 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Llc0p-0000mx-31 for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2009 00:43:51 -0400 Original-Received: from [199.232.76.173] (port=49878 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Llc0o-0000mn-SD for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2009 00:43:46 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:44643) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Llc0o-0005dK-9S for bug-gnu-emacs@gnu.org; Mon, 23 Mar 2009 00:43:46 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2N4hiuW008157; Sun, 22 Mar 2009 21:43:44 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2N4U3cO004591; Sun, 22 Mar 2009 21:30:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 23 Mar 2009 04:30:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2738 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2738-submit@emacsbugs.donarmstrong.com id=B2738.12377820633068 (code B ref 2738); Mon, 23 Mar 2009 04:30:03 +0000 Original-Received: (at 2738) by emacsbugs.donarmstrong.com; 23 Mar 2009 04:21:03 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mtaout6.012.net.il (mtaout6.012.net.il [84.95.2.16]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2N4Kwsm003061 for <2738@emacsbugs.donarmstrong.com>; Sun, 22 Mar 2009 21:21:00 -0700 Original-Received: from conversion-daemon.i-mtaout6.012.net.il by i-mtaout6.012.net.il (HyperSendmail v2007.08) id <0KGX00000YK9FP00@i-mtaout6.012.net.il> for 2738@emacsbugs.donarmstrong.com; Mon, 23 Mar 2009 06:20:52 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([77.127.23.114]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KGX00MY7YQR6200@i-mtaout6.012.net.il>; Mon, 23 Mar 2009 06:20:52 +0200 (IST) In-reply-to: <20090322225915.GA4466@muc.de> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Mon, 23 Mar 2009 00:43:51 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26564 Archived-At: > Date: Sun, 22 Mar 2009 22:59:15 +0000 > Cc: 2738@emacsbugs.donarmstrong.com > From: Alan Mackenzie > > > Is this good enough to close the bug? If not, please tell what still > > needs improvement. > > I don't think it is. I'm not sure this function can be documented > coherently. I think it's a bad function. Sorry, I'm not being very > constructive here. I just find the whole thing distasteful in the > extreme, the idea that rather than binding commands to key sequences, > with a clean separation between the interactive commander, the key > sequences and the commands, we've now got a hodge podge where the > command loop now actually performs part of a command's function - > sometimes, depending on the key binding. > > In fact, how about just saying something like "this function ensures the > mark is set for a movement command making a CUA region", or something > like that? > > In addition this, the function is buggy. It spuriously enables > transient-mark-mode in certain circumstances (I'll be submitting a bug > report soon). Well, I'm sure doc strings cannot fix buggy or bad implementation, so please do submit a separate bug report about that.