From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Diff mode faces Date: Sat, 16 Jul 2005 14:17:02 +0300 Message-ID: References: <87oea5urwm.fsf@jurta.org> <87psujj0h0.fsf@jurta.org> <86hdfv1y9b.fsf@blue.stonehenge.com> <87r7eyqzcy.fsf@jurta.org> <200506191710.j5JHAEN11479@raven.dms.auburn.edu> <877jgfi40l.fsf@jurta.org> <874qb7k65j.fsf@jurta.org> <87fyunwph1.fsf@jurta.org> <87mzoudrff.fsf@jurta.org> <87slyllarb.fsf-monnier+emacs@gnu.org> <87wtnw4isu.fsf@jurta.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1121513389 11463 80.91.229.2 (16 Jul 2005 11:29:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 16 Jul 2005 11:29:49 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 16 13:29:47 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DtkrE-0006jq-GC for ged-emacs-devel@m.gmane.org; Sat, 16 Jul 2005 13:29:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dtkt3-0000FP-Ls for ged-emacs-devel@m.gmane.org; Sat, 16 Jul 2005 07:31:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dtkp3-00081u-6I for emacs-devel@gnu.org; Sat, 16 Jul 2005 07:27:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dtkox-000803-A5 for emacs-devel@gnu.org; Sat, 16 Jul 2005 07:27:04 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dtkow-0007rr-85 for emacs-devel@gnu.org; Sat, 16 Jul 2005 07:27:02 -0400 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dtknn-0007GR-Ih for emacs-devel@gnu.org; Sat, 16 Jul 2005 07:25:51 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-54-157.inter.net.il [80.230.54.157]) by legolas.inter.net.il (MOS 3.5.8-GR) with ESMTP id EXI93264 (AUTH halo1); Sat, 16 Jul 2005 14:17:02 +0300 (IDT) Original-To: Juri Linkov In-reply-to: <87wtnw4isu.fsf@jurta.org> (message from Juri Linkov on Tue, 12 Jul 2005 09:51:05 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:40994 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:40994 > From: Juri Linkov > Cc: eliz@gnu.org, emacs-devel@gnu.org > Date: Tue, 12 Jul 2005 09:51:05 +0300 > > Here is a new patch: I tried that on a tty. I'm mildly worried about the visibility of green on (the default) white background: is it possible that it will stand out too much? If it's possible, then this change is not good, since `shadow' should not stand out. But in my case, it didn't stand out, so I have no objections for this change. > Index: lisp/faces.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v > retrieving revision 1.329 > diff -u -r1.329 faces.el > --- lisp/faces.el 4 Jul 2005 23:08:54 -0000 1.329 > +++ lisp/faces.el 12 Jul 2005 06:33:20 -0000 > @@ -2149,8 +2148,10 @@ > :version "22.1") > > (defface shadow > - '((((background dark)) :foreground "grey70") > - (((background light)) :foreground "grey50")) > + '((((min-colors 88) (background light)) :foreground "grey50") > + (((min-colors 88) (background dark)) :foreground "grey70") > + (((background light)) :foreground "green") > + (((background dark)) :foreground "yellow")) > "Basic face for shadowed text." > :group 'basic-faces > :version "22.1") > > Index: lisp/diff-mode.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/diff-mode.el,v > retrieving revision 1.78 > diff -u -r1.78 diff-mode.el > --- lisp/diff-mode.el 4 Jul 2005 23:08:52 -0000 1.78 > +++ lisp/diff-mode.el 12 Jul 2005 06:35:03 -0000 > @@ -259,7 +280,7 @@ > (defvar diff-function-face 'diff-function) > > (defface diff-context > - '((t :inherit shadow)) > + '((((min-colors 88)) :inherit shadow)) > "`diff-mode' face used to highlight context and other side-information." > :group 'diff-mode) > ;; backward-compatibility alias