From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.bugs Subject: Re: bug#141: Process sentinel not called in batch mode Date: Fri, 16 May 2008 23:07:44 +0300 Message-ID: References: <87hcd1kcmz.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1210968504 7622 80.91.229.12 (16 May 2008 20:08:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 May 2008 20:08:24 +0000 (UTC) Cc: 141@emacsbugs.donarmstrong.com, rms@gnu.org, cyd@stupidchicken.com, eller.helmut@gmail.com, emacs-devel@gnu.org, bug-submit-list@donarmstrong.com, bug-gnu-emacs@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 16 22:08:59 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jx6EL-0002Gp-QJ for ged-emacs-devel@m.gmane.org; Fri, 16 May 2008 22:08:42 +0200 Original-Received: from localhost ([127.0.0.1]:59174 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jx6Dc-0007M8-6V for ged-emacs-devel@m.gmane.org; Fri, 16 May 2008 16:07:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jx6DX-0007HN-UB for emacs-devel@gnu.org; Fri, 16 May 2008 16:07:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jx6DW-0007Dk-Gm for emacs-devel@gnu.org; Fri, 16 May 2008 16:07:51 -0400 Original-Received: from [199.232.76.173] (port=41679 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jx6DU-00079p-Gu; Fri, 16 May 2008 16:07:48 -0400 Original-Received: from mtaout6.012.net.il ([84.95.2.16]:56996) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jx6DQ-0002uv-Eu; Fri, 16 May 2008 16:07:44 -0400 Original-Received: from HOME-C4E4A596F7 ([83.130.255.47]) by i-mtaout6.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K0Z00MCU9X5YFC1@i-mtaout6.012.net.il>; Fri, 16 May 2008 23:22:18 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 10 (1203?) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97287 gmane.emacs.bugs:18022 Archived-At: > From: Stefan Monnier > Cc: rms@gnu.org, 141@emacsbugs.donarmstrong.com, cyd@stupidchicken.com, eller.helmut@gmail.com, emacs-devel@gnu.org, bug-submit-list@donarmstrong.com, bug-gnu-emacs@gnu.org > Date: Fri, 16 May 2008 15:24:04 -0400 > > >> >> This side I understand, but what about the other: why should we not > >> >> check process status in the case where we are not redisplaying? > >> > >> > Because Emacs generally looks at process output only when it's idle? > >> > >> I don't follow: we're talking about when should > >> wait_reading_process_output check status_notify. > >> > >> So to repeat/rephrase my question: why doesn't > >> wait_reading_process_output call status_notify when it is passed a zero > >> do_display? > > > Sorry, let me explain my line of thought in more detail: Emacs only > > does a redisplay when it is idle. Emacs also checks input from > > subprocesses when it is idle. If we are not in redisplay, it means > > Emacs is not idle, and so it makes sense not to check for subprocess > > output at that time. > > > Does this make any sense? > > But if we're in wait_reading_process_output, that means that idle or > not, we're checking for process output, so why not check for process > status changes as well? Because status_notify has a side effect of triggering redisplay.