From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Reviewing changes
Date: Fri, 21 Nov 2008 13:28:31 +0200
Message-ID: <umyftjp28.fsf@gnu.org>
References: <E1KvFgL-00034A-Gp@cvs.savannah.gnu.org>
	<87y6zggnmz.fsf@red-bean.com> <umyfvle4v.fsf@gnu.org>
	<87d4grbcc0.fsf@red-bean.com>
	<jwvr657p2r8.fsf-monnier+emacs@gnu.org> <uabbvkp3u.fsf@gnu.org>
	<jwv63miqxmy.fsf-monnier+emacs@gnu.org> <u7i6ykv56.fsf@gnu.org>
	<jwvhc61ohlf.fsf-monnier+emacs@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: ger.gmane.org 1227267046 24061 80.91.229.12 (21 Nov 2008 11:30:46 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 21 Nov 2008 11:30:46 +0000 (UTC)
Cc: kfogel@red-bean.com, cyd@stupidchicken.com, emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 21 12:31:47 2008
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1L3UEj-0002xW-62
	for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 12:31:45 +0100
Original-Received: from localhost ([127.0.0.1]:50482 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1L3UDZ-0002Kk-O4
	for ged-emacs-devel@m.gmane.org; Fri, 21 Nov 2008 06:30:33 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L3UBj-0001jk-CN
	for emacs-devel@gnu.org; Fri, 21 Nov 2008 06:28:39 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L3UBi-0001j5-Hb
	for emacs-devel@gnu.org; Fri, 21 Nov 2008 06:28:38 -0500
Original-Received: from [199.232.76.173] (port=55869 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L3UBi-0001iz-CK
	for emacs-devel@gnu.org; Fri, 21 Nov 2008 06:28:38 -0500
Original-Received: from mtaout5.012.net.il ([84.95.2.13]:42846)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <eliz@gnu.org>) id 1L3UBj-00006D-7c
	for emacs-devel@gnu.org; Fri, 21 Nov 2008 06:28:39 -0500
Original-Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il
	(HyperSendmail v2004.12) id
	<0KAO00H00LAC5P00@i_mtaout5.012.net.il> for emacs-devel@gnu.org;
	Fri, 21 Nov 2008 13:30:31 +0200 (IST)
Original-Received: from HOME-C4E4A596F7 ([77.126.14.29]) by i_mtaout5.012.net.il
	(HyperSendmail v2004.12) with ESMTPA id
	<0KAO00H3WLAU6K00@i_mtaout5.012.net.il>;
	Fri, 21 Nov 2008 13:30:31 +0200 (IST)
In-reply-to: <jwvhc61ohlf.fsf-monnier+emacs@gnu.org>
X-012-Sender: halo1@inter.net.il
X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:105884
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/105884>

> So you object to naming them "code reviews"?  That's OK, let's call them
> "random comments", then.
> 
> I just can't see how encouraging such random comments can hurt.

I didn't say it will hurt.  I said it won't help us make the code
quality better, which I assumed what this was all about.  Sounds like
my assumption was wrong.