From: Eli Zaretskii <eliz@gnu.org>
To: Dan Nicolaescu <dann@ics.uci.edu>, 1483@emacsbugs.donarmstrong.com
Cc: bug-gnu-emacs@gnu.org, jasonr@f2s.com
Subject: bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c
Date: Wed, 03 Dec 2008 20:30:30 +0200 [thread overview]
Message-ID: <uljuxnmbd.fsf@gnu.org> (raw)
In-Reply-To: <200812031524.mB3FOBqt025290@mothra.ics.uci.edu>
> Date: Wed, 3 Dec 2008 07:24:11 -0800 (PST)
> From: Dan Nicolaescu <dann@ics.uci.edu>
> Cc: 1483@emacsbugs.donarmstrong.com
>
> jasonr@f2s.com writes:
>
> > Quoting Dan Nicolaescu <dann@ics.uci.edu>:
> >
> > > NO_SOCKETS_IN_FILE_SYSTEM is the same as WINDOWSNT, so better replace it
> > > and have one less identifier to worry about.
> >
> > Does DOS have unix domain sockets?
>
> Is DOS using emacsclient?
No, it doesn't. And probably never will (emacsclient does not work at
all in the MS-DOS port).
But I agree with Jason and Juanma: replacing the above symbol with
just WINDOWSNT gains very little, but obfuscates the condition being
tested. If anything, I'd support the opposite changes: replace each
and every ugly system name such as WINDOWSNT with a meaningful symbol
whose name would explain what is the underlying (mis)feature.
prev parent reply other threads:[~2008-12-03 18:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 6:35 bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c Dan Nicolaescu
2008-12-03 8:03 ` jasonr
2008-12-03 15:24 ` Dan Nicolaescu
2008-12-03 15:33 ` Juanma Barranquero
2008-12-03 19:15 ` Dan Nicolaescu
2008-12-03 21:08 ` Juanma Barranquero
2008-12-03 22:03 ` Dan Nicolaescu
2008-12-03 22:15 ` Juanma Barranquero
2008-12-03 23:51 ` Juanma Barranquero
2008-12-04 4:13 ` Eli Zaretskii
2011-07-04 11:34 ` Juanma Barranquero
2008-12-03 18:30 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uljuxnmbd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=1483@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=dann@ics.uci.edu \
--cc=jasonr@f2s.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.