browse-url-galeon incorrect

browse-url-galeon incorrect

[Paul Smith]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.2.1 (i386-debian-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2002-03-22 on raven, modified by Debian
configured using `configure  i386-debian-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --with-x=yes --with-x-toolkit=athena --without-gif'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: 
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

The browse-url.el:browse-url-galeon function is wrong.  It constructs
the arguments to Galeon like this:

      (concat "galeon " url) nil
      browse-url-galeon-program
      (append
      browse-url-galeon-arguments
      (if new-window '("-w" "--noraise"))
      (list "-x" url))

This is broken, though.  The "-x" argument overrides the setting of the
new-window flag; "-x" means "Attempt to load URL in existing Galeon
window", and the last such argument on the command line always takes
precedence.  I think the "-x" should be removed, as I think it's not
appropriate to have no way of passing _exactly_ the arguments you want,
and only those.


Recent input:
<help-echo> <switch-frame> <down-mouse-2> <mouse-2> 
<switch-frame> <help-echo> <help-echo> <switch-frame> 
C-h v b r o <tab> n <tab> w <tab> ` <backspace> <return> 
<help-echo> <down-mouse-2> <mouse-2> M-f M-f M-b C-s 
C-w C-w C-w C-w C-w C-s C-s C-s C-a C-s g a l e o n 
C-s C-s C-s C-n C-a C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-l C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-l C-e C-n C-e M-x e m a c s - <M-backspace> 
r e p o <tab> o <tab> r <backspace> r <tab> <backspace> 
<backspace> r <tab> <return>

Recent messages:
Scanning buffer for index ( 45%)
Scanning buffer for index ( 52%)
Scanning buffer for index ( 58%)
Scanning buffer for index ( 64%)
Scanning buffer for index ( 70%)
Scanning buffer for index ( 76%)
Scanning buffer for index (100%)
Mark saved where search started [2 times]
Making completion list...
Loading /usr/share/emacs/21.2/lisp/mail/emacsbug.elc...done


-- 
-------------------------------------------------------------------------------
 Paul D. Smith <pausmith@nortelnetworks.com> HASMAT: HA Software Mthds & Tools
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist
-------------------------------------------------------------------------------
   These are my opinions---Nortel Networks takes no responsibility for them.

Re: browse-url-galeon incorrect

[Simon Josefsson]

"Paul Smith"<pausmith@nortelnetworks.com> writes:

> The browse-url.el:browse-url-galeon function is wrong.  It constructs
> the arguments to Galeon like this:
>
>       (concat "galeon " url) nil
>       browse-url-galeon-program
>       (append
>       browse-url-galeon-arguments
>       (if new-window '("-w" "--noraise"))
>       (list "-x" url))
>
> This is broken, though.  The "-x" argument overrides the setting of the
> new-window flag; "-x" means "Attempt to load URL in existing Galeon
> window", and the last such argument on the command line always takes
> precedence.  I think the "-x" should be removed, as I think it's not
> appropriate to have no way of passing _exactly_ the arguments you want,
> and only those.

The current code has been changed into the following.  Does it work
better for you?

...
         (process (apply 'start-process
			 (concat "galeon " url) nil
			 browse-url-galeon-program
			 (append
			  browse-url-galeon-arguments
                          (if (browse-url-maybe-new-window new-window)
			      (if browse-url-galeon-new-window-is-tab
				  '("--new-tab")
				'("--new-window" "--noraise"))
                            '("--existing"))
                          (list url)))))
...

Re: browse-url-galeon incorrect

[Sunil Patel]

Ummm...while you're editing the real code in CVS...could add support for
Opera too? (unless you've already done it!)....

        -Sunil

Re: browse-url-galeon incorrect

[Simon Josefsson]

ssp@pcdoh.wpc.frco.com (Sunil Patel) writes:

> Ummm...while you're editing the real code in CVS...could add support for
> Opera too? (unless you've already done it!)....

Sorry, Richard didn't want to add support for more non-free browsers,
if I recall correctly.

Re: browse-url-galeon incorrect

[Richard Stallman]

We are not going to add support for Opera because it is not free
software.  We support Netscape and Mosaic for historical reasons,
because they are or were very popular, but we are not going to add any
more non-free browsers.  We want to discourage the use of Opera.

Re: browse-url-galeon incorrect

[Christopher S. Kush]

Simon Josefsson writes:
> [a reply to a message my server didn't get]
> ssp@pcdoh.wpc.frco.com (Sunil Patel) writes:
> > Ummm...while you're editing the real code in CVS...could add support for
> > Opera too? (unless you've already done it!)....

You can just customize

    browse-url-netscape-program

to be "opera".

-- 
   "One does not wait for (X)Emacs to load,
    one jumps up and down with excitement."
                   -- Henrik Enberg

Re: browse-url-galeon incorrect

[Sunil Patel]

     > You can just customize
     >     browse-url-netscape-program
     > to be "opera".

That's the obvious first thing I tried...but on my Win2k machine...Opera
doesn't seem to grok the exact same arguements as netscape...it barfs with
an error....I have better luck with:

(setq browse-url-browser-function (quote browse-url-default-windows-browser))

and let the windows figure it out...

        -Sunil