From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] adding maximize to fullscreen frame parameters Date: Sat, 23 Aug 2008 21:09:01 +0300 Message-ID: References: <87wsidphul.fsf@kanis.fr> <87fxowma4d.fsf_-_@kanis.fr> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1219514955 6055 80.91.229.12 (23 Aug 2008 18:09:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 23 Aug 2008 18:09:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ivan Kanis Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 23 20:10:09 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KWxYt-0001pY-BD for ged-emacs-devel@m.gmane.org; Sat, 23 Aug 2008 20:10:07 +0200 Original-Received: from localhost ([127.0.0.1]:45076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWxXv-0004yk-Md for ged-emacs-devel@m.gmane.org; Sat, 23 Aug 2008 14:09:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWxXq-0004wb-TU for emacs-devel@gnu.org; Sat, 23 Aug 2008 14:09:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWxXq-0004vu-Bv for emacs-devel@gnu.org; Sat, 23 Aug 2008 14:09:02 -0400 Original-Received: from [199.232.76.173] (port=40908 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWxXq-0004vl-85 for emacs-devel@gnu.org; Sat, 23 Aug 2008 14:09:02 -0400 Original-Received: from mtaout5.012.net.il ([84.95.2.13]:22819) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KWxXp-0004Xz-OK for emacs-devel@gnu.org; Sat, 23 Aug 2008 14:09:02 -0400 Original-Received: from HOME-C4E4A596F7 ([84.229.211.50]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K6200LLSFRWXGG1@i_mtaout5.012.net.il> for emacs-devel@gnu.org; Sat, 23 Aug 2008 21:09:32 +0300 (IDT) In-reply-to: <87fxowma4d.fsf_-_@kanis.fr> X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102881 Archived-At: > From: Ivan Kanis > Date: Sat, 23 Aug 2008 10:03:14 +0200 > > This patch against CVS HEAD is based on Tom's proposition. Sorry if > it's repost, I am not sure the fist made it made it to the > newsgroup. I will gladly write the changelog if someone plans to > commit it. Thanks. Allow me a few comments on the documentation pieces: > +size of the screen. The value @code{maximize} specifies that both the > +width and the height shall be set to the size of the screen. The value > +@code{fullboth} toggles fullscreen mode, all windows decoration are hidden > +such as title bar and border. The desktop taskbar is also hidden so it > +looks like emacs is running on a console. Please leave two spaces after a period that ends a sentence. Also, I don't think "fullscreen" is a word (in "fullscreen mode"); I suggest to use "full-screen" in this context. > + /* Maximise in X is full height plus full width */ > + if (f->want_fullscreen == FULLSCREEN_MAXIMIZE) > + { > + f->want_fullscreen = FULLSCREEN_HEIGHT; > + XTfullscreen_hook(f); > + f->want_fullscreen = FULLSCREEN_WIDTH; > + XTfullscreen_hook(f); > + } > + else if (f->async_visible) Why are you call XTfullscreen_hook twice here?