From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: emacsclient on WXP does not work (as it used to)
Date: Fri, 31 Oct 2008 13:15:53 +0200 [thread overview]
Message-ID: <uk5bpvwuu.fsf@gnu.org> (raw)
In-Reply-To: <f7ccd24b0810310402v6a2fc2f7x959f0c23dc37806a@mail.gmail.com>
> Date: Fri, 31 Oct 2008 12:02:12 +0100
> From: "Juanma Barranquero" <lekktu@gmail.com>
> Cc: Emacs Devel <emacs-devel@gnu.org>
>
> Yes, this change:
>
> http://cvs.savannah.gnu.org/viewvc/emacs/emacs/lib-src/emacsclient.c?r1=1.135&r2=1.136&pathrev=MAIN
>
> is wrong, because on Windows, once inside the if(), tty_name is always
> going to be NULL.
Can you please explain why is this a problem on Windows? I understand
that the addition of current_frame to the `if' clause causes it to be
entered on Windows, whereas it wasn't before, but how does that, and
the fact that tty_name is NULL, cause emacsclient failure reported by
dhruva?
> I wonder why the whole if isn't just #ifdef'd out. Are there
> legitimate uses of tty == 1 on Windows?
>
> The attached patch fixes the problem, but it's ugly as hell.
Agreed (to the ``ugly'' part). I'd like to try to find a less ugly
fix.
next prev parent reply other threads:[~2008-10-31 11:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 10:35 emacsclient on WXP does not work (as it used to) dhruva
2008-10-31 11:02 ` Juanma Barranquero
2008-10-31 11:15 ` Eli Zaretskii [this message]
2008-10-31 12:27 ` Juanma Barranquero
2008-10-31 12:46 ` dhruva
2008-10-31 12:52 ` dhruva
2008-10-31 12:53 ` Juanma Barranquero
2008-10-31 12:57 ` dhruva
2008-10-31 12:52 ` Juanma Barranquero
2008-10-31 12:58 ` dhruva
2008-10-31 13:10 ` Juanma Barranquero
2008-10-31 13:38 ` dhruva
2008-10-31 13:40 ` dhruva
2008-10-31 14:22 ` Juanma Barranquero
2008-10-31 14:27 ` Juanma Barranquero
2008-10-31 14:29 ` dhruva
2008-10-31 14:13 ` Chong Yidong
2008-10-31 14:14 ` Juanma Barranquero
2008-10-31 14:44 ` Eli Zaretskii
2008-10-31 15:21 ` dhruva
2008-11-01 13:53 ` Eli Zaretskii
2008-11-01 14:55 ` Juanma Barranquero
2008-11-01 16:41 ` Eli Zaretskii
2008-11-01 17:01 ` Eli Zaretskii
2008-11-02 4:03 ` Juanma Barranquero
2008-11-02 4:19 ` Eli Zaretskii
2008-11-01 17:02 ` Eli Zaretskii
2008-11-02 2:59 ` dhruva
2008-11-02 4:17 ` Eli Zaretskii
2008-10-31 21:58 ` Andreas Schwab
2008-10-31 14:31 ` Newsticker is jealous Paul R
2008-10-31 14:43 ` Paul R
2008-10-31 17:21 ` Ulf Jasper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uk5bpvwuu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.