bug#66721: 29.1; make sanity-check fails

bug#66721: 29.1; make sanity-check fails

[Ulrich Mueller]

Forwarding downstream bug https://bugs.gentoo.org/916180:

Building Emacs aborts with:
"make all" succeeded, but Emacs is not functional.

Adding the --quick option fixes it (and may indicate that the user's
installed packages must be updated for Emacs 29). In either case, local
add-ons and configuration shouldn't break the build of Emacs itself.

I propose the trivial patch below, preferably for the emacs-29 branch.


From 7d7cffda86cf85e8f8dd5635ac03671787f553da Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ulrich=20M=C3=BCller?= <ulm@gentoo.org>
Date: Tue, 24 Oct 2023 07:53:17 +0200
Subject: [PATCH] * Makefile.in (sanity-check): Add --quick option.

---
 Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.in b/Makefile.in
index 0ab34c8be6a..49c57db1cd3 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -417,7 +417,7 @@ advice-on-failure:
 
 sanity-check:
 	@[ -f .no-advice-on-failure ] && exit 0; true
-	@v=$$(src/emacs${EXEEXT} --batch --eval \
+	@v=$$(src/emacs${EXEEXT} --batch --quick --eval \
 	  '(progn (defun f (n) (if (= 0 n) 1 (* n (f (- n 1))))) (princ (f 10)))' \
 	  2> /dev/null); \
 	[ "X$$v" = "X3628800" ] && exit 0; \
-- 
2.42.0

bug#66721: 29.1; make sanity-check fails

[Eli Zaretskii]

> From: Ulrich Mueller <ulm@gentoo.org>
> Date: Tue, 24 Oct 2023 08:24:13 +0200
> 
> Forwarding downstream bug https://bugs.gentoo.org/916180:
> 
> Building Emacs aborts with:
> "make all" succeeded, but Emacs is not functional.
> 
> Adding the --quick option fixes it (and may indicate that the user's
> installed packages must be updated for Emacs 29). In either case, local
> add-ons and configuration shouldn't break the build of Emacs itself.

One could argue (although I personally will not necessarily agree)
that making sure site-lisp loads fine _is_ part of the sanity check,
since a failure to load that is not necessarily due to problem in
site-lisp, it could be a problem with the built Emacs.

> I propose the trivial patch below, preferably for the emacs-29 branch.

Thanks, but I don't think it's trivial, so please install it on
master, as I don't want any changes in the build at this late stage of
Emacs 29 release cycle.

Also, please use -Q, not --quick, as I think the former is more
familiar.

bug#66721: 29.1; make sanity-check fails

[Ulrich Mueller]

>>>>> On Tue, 24 Oct 2023, Eli Zaretskii wrote:

> One could argue (although I personally will not necessarily agree)
> that making sure site-lisp loads fine _is_ part of the sanity check,
> since a failure to load that is not necessarily due to problem in
> site-lisp, it could be a problem with the built Emacs.

From a (source-based) distro point of view, the user must first update
Emacs, followed by updating any add-on packages. It's a logical dilemma
if the first step can fail because of outdated add-on packages.

>> I propose the trivial patch below, preferably for the emacs-29 branch.

> Thanks, but I don't think it's trivial, so please install it on
> master, as I don't want any changes in the build at this late stage of
> Emacs 29 release cycle.

I fail to see any potential for breakage there, but whatever.

> Also, please use -Q, not --quick, as I think the former is more
> familiar.

Done.