Wrong entries in AUTHORS? (was: Changes to emacs/AUTHORS,v)

Wrong entries in AUTHORS? (was: Changes to emacs/AUTHORS,v)

[Reiner Steib]

On Tue, Apr 17 2007, Chong Yidong wrote on emacs-diffs:

> +Herbert Euler: changed display.texi

herberteuler@...  is Guanpeng Xu, see copyright.list on fencepost.  I
guess the corresponding ChangeLog file should be fixed.

>  Hewlett-Packard: changed emacsclient.c emacsserver.c keyboard.c server.el

Is this one correct?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Wrong entries in AUTHORS?

[Chong Yidong]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Tue, Apr 17 2007, Chong Yidong wrote on emacs-diffs:
>
>> +Herbert Euler: changed display.texi
>
> herberteuler@...  is Guanpeng Xu, see copyright.list on fencepost.  I
> guess the corresponding ChangeLog file should be fixed.

I did that.  AUTHORS will be corrected the next time it's regenerated.

>>  Hewlett-Packard: changed emacsclient.c emacsserver.c keyboard.c server.el
>
> Is this one correct?

This one comes from the `authors-fixed-entries' variable in
authors.el:

    ("Hewlett-Packard" :changed "emacsclient.c" "emacsserver.c"
     "server.el" "keyboard.c")

Re: Wrong entries in AUTHORS? (was: Changes to emacs/AUTHORS,v)

[Eli Zaretskii]

> From: Reiner Steib <reinersteib+gmane@imap.cc>
> Date: Tue, 17 Apr 2007 19:48:54 +0200
> 
> > +Herbert Euler: changed display.texi
> 
> herberteuler@...  is Guanpeng Xu, see copyright.list on fencepost.  I
> guess the corresponding ChangeLog file should be fixed.

There's no need to change the logs (changing history is something we
don't want to do, I think); we can use authors-aliases in authors.el
instead.

> >  Hewlett-Packard: changed emacsclient.c emacsserver.c keyboard.c server.el
> 
> Is this one correct?

Why not?

Re: Wrong entries in AUTHORS?

[Reiner Steib]

On Tue, Apr 17 2007, Eli Zaretskii wrote:

>> From: Reiner Steib <reinersteib+gmane@imap.cc>
>> Date: Tue, 17 Apr 2007 19:48:54 +0200
>> 
>> > +Herbert Euler: changed display.texi
>> 
>> herberteuler@...  is Guanpeng Xu, see copyright.list on fencepost.  I
>> guess the corresponding ChangeLog file should be fixed.
>
> There's no need to change the logs (changing history is something we
> don't want to do, I think); 

It was a very recent change (2007-04-07), so it's more correcting a
recent mistake than changing history, IMHO.

> we can use authors-aliases in authors.el instead.

I thought `authors-aliases' is to match different variants of the same
name, not for pseudonyms.


>> >  Hewlett-Packard: changed emacsclient.c emacsserver.c keyboard.c server.el
>> 
>> Is this one correct?
>
> Why not?

AUTHORS talks about _people_, so I wondered that a company is listed
as a person who "changed" files.  But as Chong pointed out, it seems
to be intended (`authors-fixed-entries').

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Wrong entries in AUTHORS?

[Eli Zaretskii]

> From: Reiner Steib <reinersteib+gmane@imap.cc>
> Cc: emacs-devel@gnu.org
> Date: Tue, 17 Apr 2007 23:24:23 +0200
> 
> >> herberteuler@...  is Guanpeng Xu, see copyright.list on fencepost.  I
> >> guess the corresponding ChangeLog file should be fixed.
> >
> > There's no need to change the logs (changing history is something we
> > don't want to do, I think); 
> 
> It was a very recent change (2007-04-07), so it's more correcting a
> recent mistake than changing history, IMHO.

I don't see a mistake here.

> I thought `authors-aliases' is to match different variants of the same
> name, not for pseudonyms.

Witness:

  ("Eli Zaretskii" "eliz")

and other similar entries.