From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id 0LljMPXNTGWBFgEAG6o9tA:P1 (envelope-from ) for ; Thu, 09 Nov 2023 13:17:58 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0LljMPXNTGWBFgEAG6o9tA (envelope-from ) for ; Thu, 09 Nov 2023 13:17:57 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C20114D4C for ; Thu, 9 Nov 2023 13:17:57 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699532277; a=rsa-sha256; cv=none; b=YEQ5BVBmKDXo19okS+tP6WmkI1K1tszU6UKtFcVP/0aLFbU6bdgbjYeBSIU5WbfzRsf0XJ zUFgVszmUgCsj9bDpo7IEqZlu5RnNnMoWod+0lCGdHC4/RO1RyL5HHedGDFiW8bbfNLv71 mAJmE6Mc/GVtcUz138+QCBmEHUnY95DEr2PYBkikDLBxt8iQHeOMAJCyJqZnHyjYMfwbkF Jjkv2USTB/BMAbLQUpVdWHJ3rEpzEUzef881vs7QtXeiomybrvcfJPtCcVvC5oa/P5DYQ6 B+cdnmGgIoHZTMtoCA161tHuI8VYxXWKoVaty6guPYBV+AaHZG/erHoPbLuCOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699532277; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eryPqwKxX7vAKZuglnjRL4sNy9w0D9oosupjg2lKvoQ=; b=SnOjJ08ATmVtabHrQn+7QyArSuN+z/Jb8okiPdwESoVJdnaqgG8He8q7SC5WM1vHHVNQqW qHpKd8ScLTahY6gnt1TgO21H3hClYQcTc0F9SBNTmQcaoXvjKat559J3/jQ9nSzQy128hv j0D2tXObXLfn4QpLVRxDrkIR3yCO/ogZ5Wl6ntKMnFJTfYr9fuc9gDHOtA36CiUXuQcAX3 lnBx0MesSCIrKhc9vs0cDVU/jdvCrtjIoOqip+t4HIVxC5lxP/mPzFi+K7Y48skSac+nZT 8Pe0CvITv3c7BJk/pRe6C9046YEHR08TlIih4TuBeY36SyNQ2G6Uvw5lyCdheA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r13yW-0005So-9Y; Thu, 09 Nov 2023 07:17:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r13yU-0005SQ-Kx for emacs-orgmode@gnu.org; Thu, 09 Nov 2023 07:17:30 -0500 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r13yT-0005vN-9e for emacs-orgmode@gnu.org; Thu, 09 Nov 2023 07:17:30 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1r13yQ-0005Ga-5P for emacs-orgmode@gnu.org; Thu, 09 Nov 2023 13:17:26 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: emacs-orgmode@gnu.org From: Max Nikulin Subject: Re: [TASK] Allow customizeable ditaa executable in ob-ditaa.el Date: Thu, 9 Nov 2023 19:17:19 +0700 Message-ID: References: <87wmvhnr8b.fsf@t14.reltub.ca> <871qdo5sdh.fsf@web.de> <87y1fwtkth.fsf@localhost> <87sf5f7h04.fsf@t14.reltub.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US, ru-RU In-Reply-To: <87sf5f7h04.fsf@t14.reltub.ca> Received-SPF: pass client-ip=116.202.254.214; envelope-from=geo-emacs-orgmode@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 28 X-Spam_score: 2.8 X-Spam_bar: ++ X-Spam_report: (2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FORGED_MUA_MOZILLA=2.309, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 6C20114D4C X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -4.00 X-Spam-Score: -4.00 X-TUID: QwOdnYqOJAeZ On 09/11/2023 10:17, Leo Butler wrote: > While I was reviewing the documentation, ob-doc-ditaa.org, and the > source, ob-ditaa.el, I realized that there is a simple way to run a > script file instead of a jar file. diff --git a/lisp/ob-ditaa.el b/lisp/ob-ditaa.el index fa864c7bc..4a2b09cd9 100644 --- a/lisp/ob-ditaa.el +++ b/lisp/ob-ditaa.el @@ -100,11 +100,13 @@ (defun org-babel-execute:ditaa (body params) "epstopdf" " " eps-file " -o=" (org-babel-process-file-name out-file)))) + (jar (org-string-nw-p (if eps org-ditaa-eps-jar-path org-ditaa-jar-path))) (cmd (concat org-babel-ditaa-java-cmd - " " java " " org-ditaa-jar-option " " - (shell-quote-argument - (expand-file-name - (if eps org-ditaa-eps-jar-path org-ditaa-jar-path))) + " " java + (and jar + (concat + " " org-ditaa-jar-option " " + (shell-quote-argument (expand-file-name jar)))) " " cmdline " " (org-babel-process-file-name in-file) " " (if pdf-cmd should allow to set :java to flatpak-spawn --host toolbox run /usr/bin/ditaa without abusing of org-ditaa-jar-path. Untested. It is better to avoid obstacles than to document them.