From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: jpw@pobox.com (John Paul Wallington) Newsgroups: gmane.emacs.devel,gmane.emacs.bugs Subject: Re: many lines of blabber at top of *Completions* buffer Date: Sun, 03 Sep 2006 18:08:53 +0100 Message-ID: References: <8764j06798.fsf@jidanni.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1157303421 23196 80.91.229.2 (3 Sep 2006 17:10:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 3 Sep 2006 17:10:21 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 03 19:10:20 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GJvUB-0004yf-Dz for ged-emacs-devel@m.gmane.org; Sun, 03 Sep 2006 19:10:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GJvUA-0004Vv-TW for ged-emacs-devel@m.gmane.org; Sun, 03 Sep 2006 13:10:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GJvT0-00048p-PF for emacs-devel@gnu.org; Sun, 03 Sep 2006 13:09:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GJvT0-00048c-8a for emacs-devel@gnu.org; Sun, 03 Sep 2006 13:09:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GJvSy-000483-36; Sun, 03 Sep 2006 13:09:04 -0400 Original-Received: from [207.106.133.28] (helo=proof.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GJvdI-0005YP-Tf; Sun, 03 Sep 2006 13:19:45 -0400 Original-Received: from proof (localhost [127.0.0.1]) by proof.pobox.com (Postfix) with ESMTP id BF9D729D4E; Sun, 3 Sep 2006 13:09:21 -0400 (EDT) Original-Received: from FILTH (FILTH.SHOOTYBANGBANG.COM [217.169.11.183]) by proof.sasl.smtp.pobox.com (Postfix) with ESMTP id E61216E049; Sun, 3 Sep 2006 13:09:18 -0400 (EDT) Original-To: Dan Jacobson X-Mailer: Norman X-Attribution: JPW X-Face: oX^^1Wzw=7hF+$9sbFF; "@y\k=M:/\KKp>Ix4]Nue{W[-D*|!E&nB]#ZV7!P (Dan Jacobson's message of "Sat\, 17 Jun 2006 06\:54\:59 +0800") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (windows-nt) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:59290 gmane.emacs.bugs:15301 Archived-At: Dan Jacobson writes: > rms> The first two lines are needed for beginners. > rms> You could edit the code so as to remove them. > Edit the code? Naw, want setq completions-user-maturity 'advanced. That's a good idea. How about this change ? Is it too late to install this before the pretest ? 2006-09-03 John Paul Wallington * simple.el (completion-show-help): New defcustom. (completion-setup-function): Heed it. Index: simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.812 diff -u -r1.812 simple.el --- simple.el 20 Aug 2006 12:16:58 -0000 1.812 +++ simple.el 3 Sep 2006 16:59:53 -0000 @@ -4982,6 +4982,12 @@ ;; Variables and faces used in `completion-setup-function'. +(defcustom completion-show-help t + "Non-nil means show help message in *Completions* buffer." + :type 'boolean + :version "22.1" + :group 'completion) + (defface completions-first-difference '((t (:inherit bold))) "Face put on the first uncommon character in completions in *Completions* buffer." @@ -5068,14 +5074,15 @@ (if (get-char-property element-common-end 'mouse-face) (put-text-property element-common-end (1+ element-common-end) 'font-lock-face 'completions-first-difference)))))) - ;; Insert help string. - (goto-char (point-min)) - (if (display-mouse-p) - (insert (substitute-command-keys - "Click \\[mouse-choose-completion] on a completion to select it.\n"))) - (insert (substitute-command-keys - "In this buffer, type \\[choose-completion] to \ -select the completion near point.\n\n"))))) + ;; Maybe insert help string. + (when completion-show-help + (goto-char (point-min)) + (if (display-mouse-p) + (insert (substitute-command-keys + "Click \\[mouse-choose-completion] on a completion to select it.\n"))) + (insert (substitute-command-keys + "In this buffer, type \\[choose-completion] to \ +select the completion near point.\n\n")))))) (add-hook 'completion-setup-hook 'completion-setup-function)