From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFA] Console based mouse face highlighting. Date: Thu, 17 May 2007 23:14:05 +0300 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> <17994.32856.216525.50726@kahikatea.snap.net.nz> <17994.54868.931947.611990@kahikatea.snap.net.nz> <17995.31640.399794.621018@kahikatea.snap.net.nz> <17995.53754.860573.633945@kahikatea.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179432855 16134 80.91.229.12 (17 May 2007 20:14:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 17 May 2007 20:14:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 17 22:14:14 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HomMX-0008OW-LA for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 22:14:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HomUf-0005jj-8G for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 16:22:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HomUb-0005jW-Tc for emacs-devel@gnu.org; Thu, 17 May 2007 16:22:33 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HomUa-0005j5-FZ for emacs-devel@gnu.org; Thu, 17 May 2007 16:22:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HomUa-0005j2-AY for emacs-devel@gnu.org; Thu, 17 May 2007 16:22:32 -0400 Original-Received: from romy.inter.net.il ([213.8.233.24]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HomMR-0001ZZ-El for emacs-devel@gnu.org; Thu, 17 May 2007 16:14:07 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-17-245.inter.net.il [80.230.17.245]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id HWE14553 (AUTH halo1); Thu, 17 May 2007 23:14:06 +0300 (IDT) In-reply-to: <17995.53754.860573.633945@kahikatea.snap.net.nz> (message from Nick Roberts on Thu, 17 May 2007 15:54:34 +1200) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71267 Archived-At: > From: Nick Roberts > Date: Thu, 17 May 2007 15:54:34 +1200 > Cc: emacs-devel@gnu.org > > > But it sounds like all of them but one should be called with that > > argument zero, so it shouldn't be too hard to convert them. Am I > > missing something? > > Well it means changes to write_glyphs and rif->write_glyphs in a dozen or so > places in dispnew.c, and a change to x_write_glyph in xdisp.c at least (and > perhaps w32con_write_glyphs). If you're comfortable with those changes and > still think it's the right approach, I'll do that. I suggested an alternative a few days ago: to add a new function, say, write_mouse_highlighted_glyphs, which does the same as write_glyphs, but uses the mouse face. You could then call this function in the only place where you now need write_glyphs to use the mouse face. Would this solve the problem without any unnecessary overhead?