From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning Date: Sat, 15 Mar 2008 16:10:48 +0200 Message-ID: References: <87hckt9z1u.fsf_-_@jurta.org> <878x0n1g86.fsf@jurta.org> <877ig50vta.fsf@stupidchicken.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1205590364 30619 80.91.229.12 (15 Mar 2008 14:12:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 15 Mar 2008 14:12:44 +0000 (UTC) Cc: juri@jurta.org, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 15 15:13:12 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JaX8C-0004Q2-UU for ged-emacs-devel@m.gmane.org; Sat, 15 Mar 2008 15:13:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JaX7d-0007WF-H8 for ged-emacs-devel@m.gmane.org; Sat, 15 Mar 2008 10:12:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JaX7Z-0007VB-L6 for emacs-devel@gnu.org; Sat, 15 Mar 2008 10:12:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JaX7W-0007TF-4E for emacs-devel@gnu.org; Sat, 15 Mar 2008 10:12:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JaX7V-0007TA-TJ for emacs-devel@gnu.org; Sat, 15 Mar 2008 10:12:21 -0400 Original-Received: from mtaout4.012.net.il ([84.95.2.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JaX7V-0000Jl-LP for emacs-devel@gnu.org; Sat, 15 Mar 2008 10:12:21 -0400 Original-Received: from HOME-C4E4A596F7 ([84.229.216.171]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0JXS00AUA00LWMI0@i_mtaout4.012.net.il> for emacs-devel@gnu.org; Sat, 15 Mar 2008 16:24:21 +0200 (IST) In-reply-to: <877ig50vta.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:92675 Archived-At: > From: Chong Yidong > Date: Fri, 14 Mar 2008 18:45:05 -0400 > Cc: Eli Zaretskii , emacs-devel@gnu.org > > If you really really dislike (hate?) the warning face, one thing we > could try is to make it red and non-bold on terminals that support > colors. If that's an acceptable compromise, then we can safely go > ahead and make that change. It's your call, but at this late stage in the pretest, I'd advise against _any_ changes that are not strictly necessary for a functional Emacs. Face appearance cannot be an obstacle to Emacs functionality, IMO, because it's all too easy to customize such a face. Some more data points from the history of this issue: . This problem began when Martin Rudalics made the following change: 2007-10-08 Martin Rudalics * dired.el (dired-warning): Inherit from font-lock-warning-face to make it show up with eight colors. . That change caused _all_ files' mode bits to be highlighted on MS-Windows, where the file permission default to world-writable. Therefore, I made a subsequent change: 2007-10-13 Eli Zaretskii * dired.el (dired-warn-writable): New face. (dired-warn-writable-face): New variable. (dired-font-lock-keywords): Use dired-warn-writable-face, instead of dired-warning-face, for group- and world-writable files. The new face I introduced looks the same as dired-warning did after Martin's change, except in the DOS and Windows ports, where it looks like the default face. IOW, I didn't change the visual appearance of the mode bits on Posix platforms introduced by Martin's change, I just fixed a long standing problem whereby Emacs would highlight mode bits that are normal on DOS/Windows filesystems. Now, Martin did his change for a reason, see the log entry above. It looks like the change on the trunk by Juri simply reversed Martin's change (modulo face renaming), which means we are now back at the problem whereby world-writable files will not stand out on 8-color text terminals. At the very least, we should take care of that original problem on the trunk.