all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: juri@jurta.org, emacs-devel@gnu.org
Subject: Re: 23.0.50; Middle w in of permissions in dired-mode is red and bold: dired-warning
Date: Sat, 15 Mar 2008 16:10:48 +0200	[thread overview]
Message-ID: <uhcf8hyc7.fsf@gnu.org> (raw)
In-Reply-To: <877ig50vta.fsf@stupidchicken.com>

> From: Chong Yidong <cyd@stupidchicken.com>
> Date: Fri, 14 Mar 2008 18:45:05 -0400
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> If you really really dislike (hate?) the warning face, one thing we
> could try is to make it red and non-bold on terminals that support
> colors.  If that's an acceptable compromise, then we can safely go
> ahead and make that change.

It's your call, but at this late stage in the pretest, I'd advise
against _any_ changes that are not strictly necessary for a functional
Emacs.  Face appearance cannot be an obstacle to Emacs functionality,
IMO, because it's all too easy to customize such a face.

Some more data points from the history of this issue:

 . This problem began when Martin Rudalics made the following change:

    2007-10-08  Martin Rudalics  <rudalics@gmx.at>

	    * dired.el (dired-warning): Inherit from font-lock-warning-face to
	    make it show up with eight colors.

 . That change caused _all_ files' mode bits to be highlighted on
   MS-Windows, where the file permission default to world-writable.
   Therefore, I made a subsequent change:

    2007-10-13  Eli Zaretskii  <eliz@gnu.org>

	    * dired.el (dired-warn-writable): New face.
	    (dired-warn-writable-face): New variable.
	    (dired-font-lock-keywords): Use dired-warn-writable-face, instead
	    of dired-warning-face, for group- and world-writable files.
 
   The new face I introduced looks the same as dired-warning did after
   Martin's change, except in the DOS and Windows ports, where it
   looks like the default face.

   IOW, I didn't change the visual appearance of the mode bits on
   Posix platforms introduced by Martin's change, I just fixed a long
   standing problem whereby Emacs would highlight mode bits that are
   normal on DOS/Windows filesystems.

Now, Martin did his change for a reason, see the log entry above.  It
looks like the change on the trunk by Juri simply reversed Martin's
change (modulo face renaming), which means we are now back at the
problem whereby world-writable files will not stand out on 8-color
text terminals.  At the very least, we should take care of that
original problem on the trunk.




  parent reply	other threads:[~2008-03-15 14:10 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-13 18:02 23.0.50; Middle ``w´´ in of permissions in dired-mode is red and bold: dired-warning Peter Dyballa
2007-10-13 18:22 ` 23.0.50; Middle ``wŽŽ " martin rudalics
2007-10-13 18:41   ` Peter Dyballa
2007-10-13 19:44     ` 23.0.50; Middle ``w▌▌ " Glenn Morris
2007-10-13 20:37     ` Re: 23.0.50; Middle ``wŽŽ " Eli Zaretskii
2007-10-13 21:30       ` Peter Dyballa
2007-10-13 23:24         ` Miles Bader
2007-10-14  4:10           ` Eli Zaretskii
2007-10-14  4:03         ` Eli Zaretskii
2007-10-14  5:40           ` Re: 23.0.50; Middle ``wZZ " Drew Adams
2007-10-14 20:24             ` Eli Zaretskii
2007-10-14 20:54               ` Drew Adams
2007-10-14 21:20                 ` Eli Zaretskii
2007-10-14 21:21               ` 23.0.50; Middle w " Juri Linkov
2007-10-14 22:20                 ` Eli Zaretskii
2008-03-13  2:19                   ` Juri Linkov
2008-03-13  4:21                     ` Eli Zaretskii
2008-03-13 10:37                       ` Juri Linkov
2008-03-13 20:16                         ` Eli Zaretskii
2008-03-14  1:07                           ` Juri Linkov
     [not found]                             ` <f7ccd24b0803140146m22e5305dy704d7415bc00f8cd@mail.gmail.com>
2008-03-14  8:48                               ` Juanma Barranquero
2008-03-14 21:30                                 ` Juri Linkov
2008-03-14 23:37                                   ` Juanma Barranquero
2008-03-15  0:17                                     ` Juri Linkov
2008-03-15  0:26                                       ` Juanma Barranquero
2008-03-14 12:12                             ` Eli Zaretskii
2008-03-14 22:45                     ` Chong Yidong
2008-03-15  0:16                       ` Juri Linkov
2008-03-15 14:27                         ` Eli Zaretskii
2008-03-15 16:20                           ` Juri Linkov
2008-03-15 18:30                             ` Eli Zaretskii
2008-03-15 14:10                       ` Eli Zaretskii [this message]
2008-03-15 16:20                         ` Juri Linkov
2008-03-15 20:44                           ` Stefan Monnier
2008-03-16 14:26                             ` martin rudalics
2008-03-16 16:29                             ` Juri Linkov
2007-10-15  0:49               ` 23.0.50; Middle ``wZZ " Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=uhcf8hyc7.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=cyd@stupidchicken.com \
    --cc=emacs-devel@gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.