* w32_abort can return
@ 2005-06-11 20:43 Eli Zaretskii
2005-06-11 21:18 ` Jason Rumney
2005-06-12 10:30 ` Richard Stallman
0 siblings, 2 replies; 5+ messages in thread
From: Eli Zaretskii @ 2005-06-11 20:43 UTC (permalink / raw)
Cc: andrewi
The W32 build of Emacs redefines `abort' thusly:
#define abort w32_abort
on s/ms-w32.h, and then defines `w32_abort' on w32fns.c. Since
config.h is included before all the other headers, when the compiler
sees stdlib.h, where there's a prototype of `abort', it thinks that
`w32_abort' is a function that doesn't return, because `abort' is
declared in stdlib.h as such.
However, `w32_abort' does in fact return, if the user clicks "Ignore"
on the dialog it pops up.
This causes the compiler to produce incorrect code for every place
where Emacs calls `abort'. It also causes a warning when compiling
w32fns.c, which is how I became aware of the problem in the first
place.
I don't see any easy way of solving this problem except if we modify
`w32_abort' to never return, even if the user clicks "Ignore".
Personally, I don't see any reason to support the Ignore option. Is
it okay to call, e.g., `exit' in that case instead of returning?
TIA
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: w32_abort can return
2005-06-11 20:43 w32_abort can return Eli Zaretskii
@ 2005-06-11 21:18 ` Jason Rumney
2005-06-12 11:33 ` Eli Zaretskii
2005-06-12 10:30 ` Richard Stallman
1 sibling, 1 reply; 5+ messages in thread
From: Jason Rumney @ 2005-06-11 21:18 UTC (permalink / raw)
Cc: andrewi, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> I don't see any easy way of solving this problem except if we modify
> `w32_abort' to never return, even if the user clicks "Ignore".
> Personally, I don't see any reason to support the Ignore option. Is
> it okay to call, e.g., `exit' in that case instead of returning?
It is better to change the dialog, for example to an MB_YESNO dialog
with the question being whether to debug or not.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: w32_abort can return
2005-06-11 20:43 w32_abort can return Eli Zaretskii
2005-06-11 21:18 ` Jason Rumney
@ 2005-06-12 10:30 ` Richard Stallman
2005-06-12 11:34 ` Eli Zaretskii
1 sibling, 1 reply; 5+ messages in thread
From: Richard Stallman @ 2005-06-12 10:30 UTC (permalink / raw)
Cc: andrewi, emacs-devel
However, `w32_abort' does in fact return, if the user clicks "Ignore"
on the dialog it pops up.
It should not return.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: w32_abort can return
2005-06-11 21:18 ` Jason Rumney
@ 2005-06-12 11:33 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2005-06-12 11:33 UTC (permalink / raw)
Cc: andrewi, emacs-devel
> From: Jason Rumney <jasonr@gnu.org>
> Date: Sat, 11 Jun 2005 22:18:20 +0100
> Cc: andrewi@gnu.org, emacs-devel@gnu.org
>
> It is better to change the dialog, for example to an MB_YESNO dialog
> with the question being whether to debug or not.
Done. Thanks for the tip.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: w32_abort can return
2005-06-12 10:30 ` Richard Stallman
@ 2005-06-12 11:34 ` Eli Zaretskii
0 siblings, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2005-06-12 11:34 UTC (permalink / raw)
Cc: andrewi, emacs-devel
> From: Richard Stallman <rms@gnu.org>
> CC: emacs-devel@gnu.org, andrewi@gnu.org
> Date: Sun, 12 Jun 2005 06:30:08 -0400
>
> However, `w32_abort' does in fact return, if the user clicks "Ignore"
> on the dialog it pops up.
>
> It should not return.
I changed it so it doesn't now.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-06-12 11:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-11 20:43 w32_abort can return Eli Zaretskii
2005-06-11 21:18 ` Jason Rumney
2005-06-12 11:33 ` Eli Zaretskii
2005-06-12 10:30 ` Richard Stallman
2005-06-12 11:34 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.