From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [RFA] Console based mouse face highlighting. Date: Thu, 17 May 2007 23:29:55 +0300 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> <17994.32856.216525.50726@kahikatea.snap.net.nz> <17994.54868.931947.611990@kahikatea.snap.net.nz> <17995.31640.399794.621018@kahikatea.snap.net.nz> <17995.53754.860573.633945@kahikatea.snap.net.nz> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1179433824 20917 80.91.229.12 (17 May 2007 20:30:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 17 May 2007 20:30:24 +0000 (UTC) Cc: nickrob@snap.net.nz, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 17 22:30:23 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Homc9-0003GY-C4 for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 22:30:21 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HomkH-0004RT-7x for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 16:38:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HomkE-0004RO-Or for emacs-devel@gnu.org; Thu, 17 May 2007 16:38:42 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HomkC-0004RC-CB for emacs-devel@gnu.org; Thu, 17 May 2007 16:38:41 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HomkC-0004R9-7m for emacs-devel@gnu.org; Thu, 17 May 2007 16:38:40 -0400 Original-Received: from nitzan.inter.net.il ([213.8.233.22]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Homc3-0003Ud-Be for emacs-devel@gnu.org; Thu, 17 May 2007 16:30:15 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-17-245.inter.net.il [80.230.17.245]) by nitzan.inter.net.il (MOS 3.7.3a-GA) with ESMTP id GTO89245 (AUTH halo1); Thu, 17 May 2007 23:29:58 +0300 (IDT) In-reply-to: (message from Stefan Monnier on Thu, 17 May 2007 10:59:36 -0400) X-detected-kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71269 Archived-At: > Cc: Eli Zaretskii , emacs-devel@gnu.org > From: Stefan Monnier > Date: Thu, 17 May 2007 10:59:36 -0400 > > > Well it means changes to write_glyphs and rif->write_glyphs in a dozen or so > > places in dispnew.c, and a change to x_write_glyph in xdisp.c at least (and > > perhaps w32con_write_glyphs). If you're comfortable with those changes and > > still think it's the right approach, I'll do that. > > It doesn't seem like it'd be a big problem as such. But I do wonder why > this is necessary now, even though it hasn't been necessary until now for > all other places where we support mouse highlighting. Actually, you will see that xdisp.c:draw_glyphs _does_ accept an argument HL which tells it to use the mouse highlight face when appropriate. So at least on X and w32 this was always necessary. msdos.c doesn't need this because it actually cheats: instead of redrawing the glyphs with the mouse face, it pokes the video memory with the attribute byte that changes the text colors, but leaves the characters themselves intact (to avoid encoding them). msdos.c can do that because, unlike on X, it knows that the mouse face can only change the text _colors_, so the characters themselves don't need to be redrawn.