From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50 compile problem on Windows XP Date: Fri, 05 Oct 2007 12:16:10 +0200 Message-ID: References: <47035169.8070402@gnu.org> <4703869F.6070909@gnu.org> <47038922.10105@gnu.org> <4705652C.5070803@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: sea.gmane.org 1191579393 20890 80.91.229.12 (5 Oct 2007 10:16:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 5 Oct 2007 10:16:33 +0000 (UTC) Cc: sridhar_ml@yahoo.com, emacs-devel@gnu.org, jasonr@gnu.org To: dhruva Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 05 12:16:30 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IdkEO-0002V6-3P for ged-emacs-devel@m.gmane.org; Fri, 05 Oct 2007 12:16:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdkEI-0000uE-Tj for ged-emacs-devel@m.gmane.org; Fri, 05 Oct 2007 06:16:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IdkEF-0000sf-Uw for emacs-devel@gnu.org; Fri, 05 Oct 2007 06:16:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IdkEE-0000qL-As for emacs-devel@gnu.org; Fri, 05 Oct 2007 06:16:19 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdkEE-0000q2-8M for emacs-devel@gnu.org; Fri, 05 Oct 2007 06:16:18 -0400 Original-Received: from heller.inter.net.il ([213.8.233.23]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IdkE9-0005TO-Rl; Fri, 05 Oct 2007 06:16:14 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-80-230-18-77.inter.net.il [80.230.18.77]) by heller.inter.net.il (MOS 3.7.3a-GA) with ESMTP id DTY93755 (AUTH halo1); Fri, 5 Oct 2007 12:16:10 +0200 (IST) In-reply-to: (message from dhruva on Fri, 5 Oct 2007 15:30:58 +0530) X-Detected-Kernel: FreeBSD 4.7-5.2 (or MacOS X 10.2-10.4) (2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80289 Archived-At: > Date: Fri, 5 Oct 2007 15:30:58 +0530 > From: dhruva > Cc: "Jason Rumney" , sridhar_ml@yahoo.com, emacs-devel@gnu.org > > On 10/5/07, Eli Zaretskii wrote: > > I still think that we should avoid a macro with a name that's > > identical to a standard function. We should rename it to something > > that cannot clash with the standard C library. > > If we are trying to overcome a limitation, IMHO, we are forced to > redifine the macro with the same name, else, we will have to make > changes in the code to use a different name. Well, of course I meant to modify all the callers of `abs' to use the alternative name! There are about 65 places in 13 source files where `abs' is used; renaming them all is a trivially simple job. > Samba project has done this sort of a thing by using function pointers > to all (almost) system API functions. On platforms which have those > APIs, they point to the system provided function and on platforms > where they are not, we implement them in a shared library (to delay > the binding and provide flexibility by just replacing the shared > library/implementation). I don't see how this experience is relevant: we are talking about a macro, not a function, and a macro whose name is reserved for a standard library function, on top of that.