From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Preprocessor defines in MS-Windows build Date: Sat, 07 Jun 2008 23:25:24 +0300 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1212870389 18398 80.91.229.12 (7 Jun 2008 20:26:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Jun 2008 20:26:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 07 22:27:12 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K550J-0004X2-8L for ged-emacs-devel@m.gmane.org; Sat, 07 Jun 2008 22:27:11 +0200 Original-Received: from localhost ([127.0.0.1]:57513 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K54zW-0005ao-1g for ged-emacs-devel@m.gmane.org; Sat, 07 Jun 2008 16:26:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K54zR-0005aj-OO for emacs-devel@gnu.org; Sat, 07 Jun 2008 16:26:17 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K54zQ-0005aX-7f for emacs-devel@gnu.org; Sat, 07 Jun 2008 16:26:16 -0400 Original-Received: from [199.232.76.173] (port=50322 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K54zQ-0005aU-2Q for emacs-devel@gnu.org; Sat, 07 Jun 2008 16:26:16 -0400 Original-Received: from mtaout5.012.net.il ([84.95.2.13]:14746) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K54zP-0001B2-OA for emacs-devel@gnu.org; Sat, 07 Jun 2008 16:26:16 -0400 Original-Received: from HOME-C4E4A596F7 ([80.230.28.131]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K2400KSO1FBOXN0@i_mtaout5.012.net.il> for emacs-devel@gnu.org; Sat, 07 Jun 2008 23:40:31 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-kernel: by monty-python.gnu.org: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98621 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Sat, 07 Jun 2008 15:04:21 -0400 > > > these are not needed, and almost all the rest can be put on > > src/s/ms-w32.h. > > Ideally src/config.h, no (tho maybe it's more difficult)? You mean, nt/config.nt (that is copied into src/config.h), right? Why is that better, btw? > Look at admin/CPP-DEFINES as well (and update/improve it whenever > possible, of course). I already did. It doesn't say anything helpful about the defines I listed, and doesn't have any additional ones. > > HAVE_NTGUI -- can be replaced with WINDOWSNT, since the W32 > > build doesn't use any other GUI > > Don't we support W32 builds without GUI? No, not AFAIK. The produced binary can be run with the -nw switch, but it has GUI support built in. > > Does someone know anything that contradicts the above? If not, I > > think we should remove those defines that are not needed anymore, and > > put those which are needed in ms-w32.h. > > Sounds fine to me, Thanks for the feedback.