From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#1133: Tool-bar and multi-tty Date: Fri, 10 Oct 2008 23:32:15 +0200 Message-ID: References: <873aj56v2p.fsf@cyd.mit.edu> <87prm8fkjn.fsf@cyd.mit.edu> <873aj48cd9.fsf@cyd.mit.edu> Reply-To: Eli Zaretskii , 1133@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1223675416 7370 80.91.229.12 (10 Oct 2008 21:50:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Oct 2008 21:50:16 +0000 (UTC) Cc: 1133@emacsbugs.donarmstrong.com, dann@ics.uci.edu, emacs-devel@gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 10 23:51:13 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KoPtB-00006V-IF for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Oct 2008 23:51:13 +0200 Original-Received: from localhost ([127.0.0.1]:36216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KoPs7-0003AT-7h for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Oct 2008 17:50:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KoPs3-0003AE-56 for bug-gnu-emacs@gnu.org; Fri, 10 Oct 2008 17:50:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KoPs0-0003A2-MM for bug-gnu-emacs@gnu.org; Fri, 10 Oct 2008 17:50:01 -0400 Original-Received: from [199.232.76.173] (port=37975 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KoPs0-00039y-HB for bug-gnu-emacs@gnu.org; Fri, 10 Oct 2008 17:50:00 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49416) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KoPs0-0005j2-1q for bug-gnu-emacs@gnu.org; Fri, 10 Oct 2008 17:50:00 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9ALnwYU007237; Fri, 10 Oct 2008 14:49:58 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m9ALe4c7004948; Fri, 10 Oct 2008 14:40:04 -0700 X-Loop: don@donarmstrong.com Resent-From: Eli Zaretskii Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 10 Oct 2008 21:40:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1133 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1133-submit@emacsbugs.donarmstrong.com id=B1133.12236743503571 (code B ref 1133); Fri, 10 Oct 2008 21:40:04 +0000 Original-Received: (at 1133) by emacsbugs.donarmstrong.com; 10 Oct 2008 21:32:30 +0000 Original-Received: from mtaout4.012.net.il (mtaout4.012.net.il [84.95.2.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9ALWQjo003565 for <1133@emacsbugs.donarmstrong.com>; Fri, 10 Oct 2008 14:32:27 -0700 Original-Received: from HOME-C4E4A596F7 ([77.127.3.182]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K8J009TPL7WMLL3@i_mtaout4.012.net.il> for 1133@emacsbugs.donarmstrong.com; Fri, 10 Oct 2008 23:33:38 +0200 (IST) In-reply-to: <873aj48cd9.fsf@cyd.mit.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 10 Oct 2008 17:50:01 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21394 Archived-At: > From: Chong Yidong > Cc: dann@ics.uci.edu, 1133@emacsbugs.donarmstrong.com, emacs-devel@gnu.org > Date: Fri, 10 Oct 2008 15:43:30 -0400 > > (defun tool-bar-setup (&optional frame) > (unless (or tool-bar-setup > ! (null tool-bar-mode)) > (with-selected-frame (or frame (selected-frame)) > ;; People say it's bad to have EXIT on the tool bar, since users > ;; might inadvertently click that button. > > > Suppose you apply this patch, and start emacs on a tty with `emacs -nw', > then start a server with M-x server-start RET. Then, open a graphical > client with `emacsclient -c'. > > The result is an ugly, low-color toolbar; not the usual high-color > toolbar. > > I thought this was due to GTK settings, but further investigation > reveals that the low-color settings come from these lines in > tool-bar-local-item-from-menu: > > (image-exp `(tool-bar-find-image > (if (display-color-p) > ',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec) > ',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec)))) > > Calling tool-bar-local-item-from-menu from the tty loads the lo-spec > images, whereas deferring this call until X is started up loads the > hi-spec images. But deferring the call, as I suggested, doesn't seem to > be satisfactory either. > > Probably the way to do this correctly is to change update_frame_tool_bar > to dynamically update the icons to deal with the latest display > settings. > > Alternatively, we could drop support for "low-color" images on the > toolbar entirely. I'd rather not drop support for low-color images, unless the dynamic update you are suggesting turns out to be too hard. Dynamically updating the icons sounds right to me, especially since we could have several frames with different color capabilities, at least in principle.