From: Eli Zaretskii <eliz@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: 1133@emacsbugs.donarmstrong.com, dann@ics.uci.edu, emacs-devel@gnu.org
Subject: Re: Tool-bar and multi-tty
Date: Fri, 10 Oct 2008 23:32:15 +0200 [thread overview]
Message-ID: <ufxn4i1b4.fsf@gnu.org> (raw)
In-Reply-To: <873aj48cd9.fsf@cyd.mit.edu>
> From: Chong Yidong <cyd@stupidchicken.com>
> Cc: dann@ics.uci.edu, 1133@emacsbugs.donarmstrong.com, emacs-devel@gnu.org
> Date: Fri, 10 Oct 2008 15:43:30 -0400
>
> (defun tool-bar-setup (&optional frame)
> (unless (or tool-bar-setup
> ! (null tool-bar-mode))
> (with-selected-frame (or frame (selected-frame))
> ;; People say it's bad to have EXIT on the tool bar, since users
> ;; might inadvertently click that button.
>
>
> Suppose you apply this patch, and start emacs on a tty with `emacs -nw',
> then start a server with M-x server-start RET. Then, open a graphical
> client with `emacsclient -c'.
>
> The result is an ugly, low-color toolbar; not the usual high-color
> toolbar.
>
> I thought this was due to GTK settings, but further investigation
> reveals that the low-color settings come from these lines in
> tool-bar-local-item-from-menu:
>
> (image-exp `(tool-bar-find-image
> (if (display-color-p)
> ',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec)
> ',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec))))
>
> Calling tool-bar-local-item-from-menu from the tty loads the lo-spec
> images, whereas deferring this call until X is started up loads the
> hi-spec images. But deferring the call, as I suggested, doesn't seem to
> be satisfactory either.
>
> Probably the way to do this correctly is to change update_frame_tool_bar
> to dynamically update the icons to deal with the latest display
> settings.
>
> Alternatively, we could drop support for "low-color" images on the
> toolbar entirely.
I'd rather not drop support for low-color images, unless the dynamic
update you are suggesting turns out to be too hard. Dynamically
updating the icons sounds right to me, especially since we could have
several frames with different color capabilities, at least in
principle.
next prev parent reply other threads:[~2008-10-10 21:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-10 2:30 Tool-bar and multi-tty Chong Yidong
2008-10-10 7:50 ` bug#1133: " Eli Zaretskii
2008-10-10 7:50 ` Eli Zaretskii
2008-10-10 7:51 ` bug#1133: " Eli Zaretskii
2008-10-10 7:51 ` Eli Zaretskii
2008-10-10 17:05 ` bug#1133: " Chong Yidong
2008-10-10 17:05 ` Chong Yidong
2008-10-10 18:27 ` bug#1133: " Eli Zaretskii
2008-10-10 18:27 ` Eli Zaretskii
2008-10-10 19:43 ` Chong Yidong
2008-10-10 19:51 ` Chong Yidong
2008-10-10 19:51 ` bug#1133: " Chong Yidong
2008-10-10 21:32 ` Eli Zaretskii
2008-10-10 21:32 ` Eli Zaretskii [this message]
2008-10-11 16:28 ` Stefan Monnier
2008-10-11 16:28 ` Stefan Monnier
2008-10-11 19:49 ` bug#1133: " Chong Yidong
2008-10-11 19:49 ` Chong Yidong
2008-10-12 8:28 ` bug#1133: " Andreas Schwab
2008-10-12 8:28 ` Andreas Schwab
2008-10-12 8:52 ` Andreas Schwab
2008-10-12 13:51 ` Chong Yidong
2008-10-12 14:31 ` Andreas Schwab
2008-10-12 17:10 ` Chong Yidong
2008-10-12 17:10 ` bug#1133: " Chong Yidong
2008-10-12 14:31 ` Andreas Schwab
2008-10-12 13:51 ` Chong Yidong
2008-10-12 8:52 ` Andreas Schwab
2008-10-10 19:43 ` Chong Yidong
2008-10-10 17:18 ` Stefan Monnier
2008-10-10 17:18 ` Stefan Monnier
2008-10-10 18:27 ` Chong Yidong
2008-10-10 18:27 ` bug#1133: " Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ufxn4i1b4.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=1133@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.