all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Platform-specific symbols in cus-start.el
@ 2009-03-21  9:48 Eli Zaretskii
  2009-03-21 12:53 ` David Reitter
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2009-03-21  9:48 UTC (permalink / raw)
  To: David Reitter; +Cc: emacs-devel

This change:

    2009-03-21  David Reitter <david.reitter@gmail.com>

	    * cus-start.el (all): add
	    `ns-{control|command|alternate|function}-modifier',
	    `ns-antialias-text' and `ns-use-qd-smoothing'

was incomplete.  You cannot just add platform-specific symbols to
cus-start.el, because building Emacs will then output warning
messages, like this:

    Loading cus-start...
    Note, built-in variable `ns-control-modifier' not bound
    Note, built-in variable `ns-command-modifier' not bound
    Note, built-in variable `ns-alternate-modifier' not bound
    Note, built-in variable `ns-function-modifier' not bound
    Note, built-in variable `ns-antialias-text' not bound
    Note, built-in variable `ns-use-qd-smoothing' not bound

You need to add something to the code that avoids warnings for symbols
that are native to specific platforms.  See the change I committed; I
have no way of testing that on NextStep, so please see that I didn't
break anything.

Also, please don't use regexp-like shorthands in ChangeLog entries, as
this is against GNU coding standards (it defeats searching for changes
using grep).  Please always state the full names of functions,
variables, files, etc.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-03-22  1:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-21  9:48 Platform-specific symbols in cus-start.el Eli Zaretskii
2009-03-21 12:53 ` David Reitter
2009-03-21 13:55   ` Stefan Monnier
2009-03-22  1:48     ` YAMAMOTO Mitsuharu
2009-03-21 14:44   ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.