From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PING] ClearType Patch Date: Wed, 08 Jun 2005 17:33:07 +0300 Message-ID: References: <1117787455.42a0153fdf46f@webmail.freedom2surf.net> <1118072836.42a47004de422@webmail.freedom2surf.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1118241240 10519 80.91.229.2 (8 Jun 2005 14:34:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 8 Jun 2005 14:34:00 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 08 16:33:49 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Dg1bC-0001uD-Cz for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 16:32:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dg1hv-0005pf-Hn for ged-emacs-devel@m.gmane.org; Wed, 08 Jun 2005 10:39:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Dg1gN-0005Kc-OL for emacs-devel@gnu.org; Wed, 08 Jun 2005 10:37:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Dg1gH-0005Gg-OQ for emacs-devel@gnu.org; Wed, 08 Jun 2005 10:37:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Dg1gH-0005G6-3S for emacs-devel@gnu.org; Wed, 08 Jun 2005 10:37:21 -0400 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Dg1fq-0001NE-PS for emacs-devel@gnu.org; Wed, 08 Jun 2005 10:36:55 -0400 Original-Received: from HOME-C4E4A596F7 (IGLD-84-228-238-226.inter.net.il [84.228.238.226]) by legolas.inter.net.il (MOS 3.5.8-GR) with ESMTP id EOK31155 (AUTH halo1); Wed, 8 Jun 2005 17:33:07 +0300 (IDT) Original-To: David Abrahams In-reply-to: (message from David Abrahams on Wed, 08 Jun 2005 09:45:16 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:38332 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:38332 > From: David Abrahams > Date: Wed, 08 Jun 2005 09:45:16 -0400 > > Sorry to be a pest, but as easy as it was, solving this problem did > take significant effort on my part. Thank you for your work. However, with only a few days past, you could have waited a few more before deciding that your patches were ignored. > So could someone please either render a judgement about how the patch > should be changed, or check it in as is, or give me CVS write > permission so I can do it myself? I'm bothered by the funky W32_* macros, so I'd like to hear from people who know more than myself about the intricacies of MSVC and MinGW whether there's no cleaner way to do this. Hard-coding macros from system headers (that's what those #define's are, right?) in Emacs doesn't sound like a good idea to me. Also, according to what I see in the MinGW headers, I'm not sure I understand the problem. I see SPI_GETFONTSMOOTHING in winuser.h, whose definition is unaffected by the value of _WIN32_WINNT. I don't see the other two constants in the MinGW headers. So please explain in more detail the problem that caused you to define your own macros: what macros you wanted to use, where they are defined, and why the value of _WIN32_WINNT prevents you from using them. Finally, MSDN seems to indicate that SPI_GETFONTSMOOTHINGTYPE is unsupported on Windows 9x, so it sounds like your code should be disabled for those versions of Windows. A ChangeLog entry for the patches would also be nice, btw.