w32_abort can return

w32_abort can return

[Eli Zaretskii]

The W32 build of Emacs redefines `abort' thusly:

    #define abort w32_abort

on s/ms-w32.h, and then defines `w32_abort' on w32fns.c.  Since
config.h is included before all the other headers, when the compiler
sees stdlib.h, where there's a prototype of `abort', it thinks that
`w32_abort' is a function that doesn't return, because `abort' is
declared in stdlib.h as such.

However, `w32_abort' does in fact return, if the user clicks "Ignore"
on the dialog it pops up.

This causes the compiler to produce incorrect code for every place
where Emacs calls `abort'.  It also causes a warning when compiling
w32fns.c, which is how I became aware of the problem in the first
place.

I don't see any easy way of solving this problem except if we modify
`w32_abort' to never return, even if the user clicks "Ignore".
Personally, I don't see any reason to support the Ignore option.  Is
it okay to call, e.g., `exit' in that case instead of returning?

TIA

Re: w32_abort can return

[Jason Rumney]

Eli Zaretskii <eliz@gnu.org> writes:

> I don't see any easy way of solving this problem except if we modify
> `w32_abort' to never return, even if the user clicks "Ignore".
> Personally, I don't see any reason to support the Ignore option.  Is
> it okay to call, e.g., `exit' in that case instead of returning?

It is better to change the dialog, for example to an MB_YESNO dialog
with the question being whether to debug or not.

Re: w32_abort can return

[Eli Zaretskii]

> From: Jason Rumney <jasonr@gnu.org>
> Date: Sat, 11 Jun 2005 22:18:20 +0100
> Cc: andrewi@gnu.org, emacs-devel@gnu.org
> 
> It is better to change the dialog, for example to an MB_YESNO dialog
> with the question being whether to debug or not.

Done.  Thanks for the tip.

Re: w32_abort can return

[Richard Stallman]

    However, `w32_abort' does in fact return, if the user clicks "Ignore"
    on the dialog it pops up.

It should not return.

Re: w32_abort can return

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> CC: emacs-devel@gnu.org, andrewi@gnu.org
> Date: Sun, 12 Jun 2005 06:30:08 -0400
> 
>     However, `w32_abort' does in fact return, if the user clicks "Ignore"
>     on the dialog it pops up.
> 
> It should not return.

I changed it so it doesn't now.