From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Global Font Lock by default Date: Wed, 02 Nov 2005 20:55:09 +0200 Message-ID: References: <200510311648.j9VGmgKN020532@scanner2.ics.uci.edu> <878xw9r3tu.fsf@pacem.orebokech.com> <200510311747.j9VHl2KN024250@scanner2.ics.uci.edu> <871x21r0v6.fsf@pacem.orebokech.com> <200510312048.j9VKm8KN006460@scanner2.ics.uci.edu> <87r7a1pf1h.fsf@pacem.orebokech.com> <200511010635.jA16ZNKN011265@scanner2.ics.uci.edu> <200511012043.jA1Kh2KN002153@scanner2.ics.uci.edu> <200511020546.jA25kjKN005165@scanner2.ics.uci.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1130957900 8636 80.91.229.2 (2 Nov 2005 18:58:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 2 Nov 2005 18:58:20 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 02 19:58:17 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EXNle-0007LF-3w for ged-emacs-devel@m.gmane.org; Wed, 02 Nov 2005 19:55:26 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EXNld-0004gv-Gm for ged-emacs-devel@m.gmane.org; Wed, 02 Nov 2005 13:55:25 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EXNlR-0004gn-Cp for emacs-devel@gnu.org; Wed, 02 Nov 2005 13:55:13 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EXNlP-0004gb-VU for emacs-devel@gnu.org; Wed, 02 Nov 2005 13:55:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EXNlP-0004gY-S2 for emacs-devel@gnu.org; Wed, 02 Nov 2005 13:55:11 -0500 Original-Received: from [192.114.186.66] (helo=romy.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EXNlQ-00048Q-03 for emacs-devel@gnu.org; Wed, 02 Nov 2005 13:55:12 -0500 Original-Received: from HOME-C4E4A596F7 (IGLD-83-130-243-144.inter.net.il [83.130.243.144]) by romy.inter.net.il (MOS 3.5.8-GR) with ESMTP id CWM35274 (AUTH halo1); Wed, 2 Nov 2005 20:55:07 +0200 (IST) Original-To: Dan Nicolaescu In-reply-to: <200511020546.jA25kjKN005165@scanner2.ics.uci.edu> (message from Dan Nicolaescu on Tue, 01 Nov 2005 21:46:43 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:45308 Archived-At: > Cc: emacs-devel@gnu.org > From: Dan Nicolaescu > Date: Tue, 01 Nov 2005 21:46:43 -0800 > > Eli Zaretskii writes: > > > > For example: on a 256 colors xterm, what should list-colors-display > > > show when using --color=8? The same as it would on a 8 color xterm > > > (and no --color options)? > > > > Yes. > > That does not happen right now. The problem is that > xterm-register-default-colors creates (display-color-cells) colors, it > does not take into account the --color parameter. That's very strange, because the code was designed so that display-color-cells _does_ take --colors into account. Here's how it was supposed to work: . display-color-cells calls tty-display-color-cells . tty-display-color-cells returns the value of TN_max_colors . TN_max_colors is modified by term.c:tty_setup_colors . tty_setup_colors is called by frame.c:store_frame_param (via set_tty_color_mode) when the frame parameters alist includes the tty-color-mode parameter . When Emacs is invoked with --colors=MODE, the startup code (in tty-handle-args) pushes the appropriate tty-color-mode parameter into the alist Which part of this isn't working, and why? > This can be fixed either in xterm-register-default-colors or in > display-color-cells. What is the preferable fix? I cannot answer this without understanding the problem. The fix should be where the bug lurks, in general.