all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* `apply-partially' in subr.el is broken
@ 2008-10-20  4:32 Miles Bader
  2008-10-20  9:41 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Miles Bader @ 2008-10-20  4:32 UTC (permalink / raw)
  To: emacs-devel

A recent change to subr.el uses a cl macro (lexical-let):

   2008-10-19  Eli Zaretskii  <eliz@gnu.org>

           * subr.el (apply-partially): Moved here from minibuffer.el.

apply-partially looks like:

   (defun apply-partially (fun &rest args)
     ...
     (lexical-let ((fun fun) (args1 args))
     ...

but subr.el does not have (eval-when-compile (require 'cl)).

Naturally, this does not compile correctly.

So either the require needs to be added or apply-partially needs to not
use lexical-let (is it ok for subr.el to use cl.el?).

Thanks,

-Miles

-- 
Congratulation, n. The civility of envy.




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: `apply-partially' in subr.el is broken
  2008-10-20  4:32 `apply-partially' in subr.el is broken Miles Bader
@ 2008-10-20  9:41 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2008-10-20  9:41 UTC (permalink / raw)
  To: Miles Bader; +Cc: emacs-devel

> From: Miles Bader <miles.bader@necel.com>
> Date: Mon, 20 Oct 2008 13:32:31 +0900
> 
> A recent change to subr.el uses a cl macro (lexical-let):
> 
>    2008-10-19  Eli Zaretskii  <eliz@gnu.org>
> 
>            * subr.el (apply-partially): Moved here from minibuffer.el.
> 
> apply-partially looks like:
> 
>    (defun apply-partially (fun &rest args)
>      ...
>      (lexical-let ((fun fun) (args1 args))
>      ...
> 
> but subr.el does not have (eval-when-compile (require 'cl)).
> 
> Naturally, this does not compile correctly.

Sorry about that.  Should be fixed now.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-20  9:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-20  4:32 `apply-partially' in subr.el is broken Miles Bader
2008-10-20  9:41 ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.